Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade roxygen2 version #36

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Upgrade roxygen2 version #36

merged 6 commits into from
Jan 24, 2024

Conversation

galachad
Copy link
Member

@galachad galachad commented Jan 24, 2024

It should also trigger upgrade of pkgbuild.

Close #35 The CI fix was done in admiralci.

@ramiromagno ramiromagno linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link

Code Coverage

Package Line Rate Health
sdtm.oak 88%
Summary 88% (241 / 273)

@ramiromagno
Copy link
Collaborator

Hi @galachad:

Thank you for your pull request.

I had a quick view over the changes and all seems good. I just integrated these changes into my PR #33 to see if the checks now pass. If everything goes smooth, then I will quickly approve this PR on my end.

Copy link
Collaborator

@ramiromagno ramiromagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @galachad:

All seems good. My PR is also passing now. Thanks!

@galachad galachad merged commit eccb9eb into main Jan 24, 2024
15 checks passed
@galachad galachad deleted the 35-fix-roxygen-gen branch January 24, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Fix Test Coverage and Roxygen workflows
2 participants