String_200 #32
Open
String_200 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is used to split the variables in a dataframe which has length > 200 into meaningful string variable with SUPP variables
|
galachad
requested changes
Dec 13, 2023
There was a problem hiding this comment.
PTAL, I added some of initial comments. @madhan0923 can we consider of using S3 methods for diffrent classes?
R/split_var_call.R
Outdated
| @@ -0,0 +1,60 @@ | |||
| R_SPLIT = function(domain_dataset,max_length_out = 200){ | |||
There was a problem hiding this comment.
- Please use tidyver styleguid and snake case https://style.tidyverse.org/syntax.html
- Please add roxygen documentation, with examples
- Please add tests cases
- Please add namesacpes:: to all functions calls from tidyverse packages
R/split_var_call.R
Outdated
| char_200 = domain_dataset %>% select_if(~ max(nchar(.)) >= max_length_out) | ||
|
|
||
| #string split function | ||
| split_var <- function(string,max_length_out = 200) { |
There was a problem hiding this comment.
Please do not keep function inside function.
R/split_var_call.R
Outdated
| split_var <- function(string,max_length_out = 200) { | ||
|
|
||
| # Pattern spot | ||
| pattern = names(which.max(table(str_extract_all(string, "[:punct:]|[:blank:]")))) %>% |
There was a problem hiding this comment.
The pattern can be used for split, but it will not work as sep in paste function.
R/split_var_call.R
Outdated
Comment on lines
46
to
54
| outt <- map(char_200, ~ { | ||
| split_list <- map(.x, ~ { | ||
| cv <- as.data.frame(split_var(.x, max_length_out)) | ||
| names(cv) <- seq_along(cv) | ||
| cv | ||
| }) | ||
| split_df <- bind_rows(split_list) | ||
| split_df | ||
| }) %>% imap(.,~set_names(.x,.y)) %>% bind_cols() |
|
@madhan0923 - Can you address the review comments? Also, merge main to this FB and make sure the pipeline is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is used to split the variables in a dataframe which has length > 200 into meaningful string variable with SUPP variables
Thank you for your Pull Request! We have developed this task checklist from the
Development Process
Guide
to help with the final steps of the process. Completing the below tasks helps to
ensure our reviewers can maximize their time on your code as well as making sure
the oak codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task
or check off that it is not relevant to your Pull Request. This checklist is
part of the Github Action workflows and the Pull Request will not be merged into
the
develbranch until you have checked off each task.Request Title (Use Edit button in top-right if you need to update)
tidyverse style guide. Run
styler::style_file()to style R and Rmd filesconsider realistic data scenarios and edge cases, e.g. empty datasets, errors,
boundary cases etc. - See
Unit Test Guide
fully follow the
deprecation guidance?
and families. Refer to the
categorization of functions to tag appropriate keyword/family.
devtools::document()so all.Rdfiles in themanfolder and theNAMESPACEfile in the project root are updated appropriatelyNEWS.mdif the changes pertain to a user-facing function (i.e. ithas an
@exporttag) or documentation aimed at users (rather than developers)pkgdown::build_site()and check that all affectedexamples are displayed correctly and that all new functions occur on the "Reference" page.
lintr::lint_package()R CMD checklocally and address all errors and warnings -devtools::check()