You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This one maybe is missing information and/or was not done correctly. Will need some investigation. Please reach out to me @bms63 for discussion before you start
Definition of Done
Functions or arguments being removed should be documented in the changelog
Function or arguments being removed based on their phase of deprecation should also be documented
Bonus points if you split them up as Phase 1, 2, 3 so easier to track!
Be sure functions/argument documents are appropriately updated and/or removed
Be sure unit tests appropriately capture deprecation where appropriate
Remove any old deprecation unit tests no longer relevant
@pharmaverse/admiral @pharmaverse/admiral_comm this is a good one to knock out!! Very helpful to us to do this in the beginning of the cycle!
The text was updated successfully, but these errors were encountered:
Hi @sadchla-codes How is it going with this issue? I have finished these updates in {admiral}, it was pretty minimal.
It's going ok, @bms63@StefanThoma since this PR is not merged yet, should that exclude quosures from the list? Also, it looks like in some programs, that argument had a stop deprecated for some time, although I'm not a 100% certain at which version
Background Information
This one maybe is missing information and/or was not done correctly. Will need some investigation. Please reach out to me @bms63 for discussion before you start
Definition of Done
@pharmaverse/admiral @pharmaverse/admiral_comm this is a good one to knock out!! Very helpful to us to do this in the beginning of the cycle!
The text was updated successfully, but these errors were encountered: