Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issue: Move deprecated arguments and functions to next phase or remove #459

Closed
6 tasks
bms63 opened this issue Aug 1, 2024 · 2 comments · Fixed by #464
Closed
6 tasks

General Issue: Move deprecated arguments and functions to next phase or remove #459

bms63 opened this issue Aug 1, 2024 · 2 comments · Fixed by #464
Assignees

Comments

@bms63
Copy link
Collaborator

bms63 commented Aug 1, 2024

Background Information

This one maybe is missing information and/or was not done correctly. Will need some investigation. Please reach out to me @bms63 for discussion before you start

image

Definition of Done

  • Functions or arguments being removed should be documented in the changelog
  • Function or arguments being removed based on their phase of deprecation should also be documented
    • Bonus points if you split them up as Phase 1, 2, 3 so easier to track!
  • Be sure functions/argument documents are appropriately updated and/or removed
  • Be sure unit tests appropriately capture deprecation where appropriate
  • Remove any old deprecation unit tests no longer relevant

@pharmaverse/admiral @pharmaverse/admiral_comm this is a good one to knock out!! Very helpful to us to do this in the beginning of the cycle!

@StefanThoma
Copy link
Collaborator

Hi @sadchla-codes
How is it going with this issue?
I have finished these updates in {admiral}, it was pretty minimal.

@sadchla-codes
Copy link
Collaborator

Hi @sadchla-codes How is it going with this issue? I have finished these updates in {admiral}, it was pretty minimal.

It's going ok, @bms63 @StefanThoma since this PR is not merged yet, should that exclude quosures from the list? Also, it looks like in some programs, that argument had a stop deprecated for some time, although I'm not a 100% certain at which version

image

In quo.R file
image

in Changelog
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants