Skip to content

Commit

Permalink
Merge pull request #242 from pharmaverse/pre-release
Browse files Browse the repository at this point in the history
Pre release
  • Loading branch information
bms63 authored Mar 7, 2023
2 parents f247139 + 061ce46 commit c0a814e
Show file tree
Hide file tree
Showing 97 changed files with 1,642 additions and 1,070 deletions.
40 changes: 0 additions & 40 deletions .github/ISSUE_TEMPLATE/05_onboard.yml

This file was deleted.

10 changes: 6 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: admiraldev
Type: Package
Title: Development Tools for the Admiral Package Family
Version: 0.2.0
Title: Utility Functions and Development Tools for the Admiral Package Family
Version: 0.3.0
Authors@R: c(
person("Ben", "Straub", email = "[email protected]", role = c("aut", "cre")),
person("Stefan", "Bundfuss", role = "aut"),
Expand Down Expand Up @@ -46,7 +46,7 @@ Suggests:
diffdf,
lintr,
pkgdown,
testthat,
testthat (>= 3.0.0),
knitr,
methods,
miniUI,
Expand All @@ -58,5 +58,7 @@ Suggests:
tibble,
usethis,
covr,
DT
DT,
htmltools
VignetteBuilder: knitr
Config/testthat/edition: 3
24 changes: 9 additions & 15 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export("%or%")
export(add_suffix_to_vars)
export(anti_join)
export(arg_name)
export(as_name)
export(assert_atomic_vector)
export(assert_character_scalar)
export(assert_character_vector)
Expand Down Expand Up @@ -39,6 +38,7 @@ export(dataset_vignette)
export(dquote)
export(enumerate)
export(expect_dfs_equal)
export(expr_c)
export(extract_vars)
export(filter_if)
export(get_constant_vars)
Expand All @@ -52,9 +52,11 @@ export(is_named)
export(is_order_vars)
export(is_valid_dtc)
export(left_join)
export(process_set_values_to)
export(quo_c)
export(quo_not_missing)
export(remove_tmp_vars)
export(replace_symbol_in_expr)
export(replace_symbol_in_quo)
export(replace_values_by_names)
export(squote)
Expand All @@ -66,6 +68,7 @@ export(warn_if_inconsistent_list)
export(warn_if_invalid_dtc)
export(warn_if_vars_exist)
export(what_is_it)
importFrom(dplyr,across)
importFrom(dplyr,arrange)
importFrom(dplyr,bind_cols)
importFrom(dplyr,bind_rows)
Expand All @@ -79,25 +82,20 @@ importFrom(dplyr,full_join)
importFrom(dplyr,group_by)
importFrom(dplyr,if_else)
importFrom(dplyr,mutate)
importFrom(dplyr,mutate_at)
importFrom(dplyr,mutate_if)
importFrom(dplyr,n)
importFrom(dplyr,n_distinct)
importFrom(dplyr,na_if)
importFrom(dplyr,pull)
importFrom(dplyr,rename)
importFrom(dplyr,rename_at)
importFrom(dplyr,row_number)
importFrom(dplyr,select)
importFrom(dplyr,slice)
importFrom(dplyr,starts_with)
importFrom(dplyr,summarise)
importFrom(dplyr,summarise_at)
importFrom(dplyr,tibble)
importFrom(dplyr,transmute)
importFrom(dplyr,ungroup)
importFrom(dplyr,union)
importFrom(dplyr,vars)
importFrom(hms,as_hms)
importFrom(lifecycle,deprecate_stop)
importFrom(lifecycle,deprecate_warn)
Expand Down Expand Up @@ -139,6 +137,7 @@ importFrom(rlang,abort)
importFrom(rlang,arg_match)
importFrom(rlang,as_function)
importFrom(rlang,as_label)
importFrom(rlang,as_name)
importFrom(rlang,as_string)
importFrom(rlang,call2)
importFrom(rlang,call_name)
Expand All @@ -151,33 +150,28 @@ importFrom(rlang,eval_tidy)
importFrom(rlang,expr)
importFrom(rlang,expr_interp)
importFrom(rlang,expr_label)
importFrom(rlang,exprs)
importFrom(rlang,f_lhs)
importFrom(rlang,f_rhs)
importFrom(rlang,inform)
importFrom(rlang,is_bare_formula)
importFrom(rlang,is_call)
importFrom(rlang,is_character)
importFrom(rlang,is_expression)
importFrom(rlang,is_formula)
importFrom(rlang,is_integerish)
importFrom(rlang,is_logical)
importFrom(rlang,is_missing)
importFrom(rlang,is_quosure)
importFrom(rlang,is_quosures)
importFrom(rlang,is_symbol)
importFrom(rlang,is_symbolic)
importFrom(rlang,missing_arg)
importFrom(rlang,new_formula)
importFrom(rlang,parse_expr)
importFrom(rlang,parse_exprs)
importFrom(rlang,quo)
importFrom(rlang,quo_get_env)
importFrom(rlang,quo_get_expr)
importFrom(rlang,quo_is_call)
importFrom(rlang,quo_is_missing)
importFrom(rlang,quo_is_null)
importFrom(rlang,quo_is_symbol)
importFrom(rlang,quo_set_env)
importFrom(rlang,quo_squash)
importFrom(rlang,quo_text)
importFrom(rlang,quos)
importFrom(rlang,set_names)
importFrom(rlang,sym)
importFrom(rlang,syms)
Expand Down
43 changes: 42 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,44 @@
# admiraldev 0.3.0

## New Features
- New function `process_set_values_to()` for creating the variables specified
by the `set_value_to` argument and catching errors (#70)

## Updates of Existing Functions
- Using testthat3e (testthat 3rd edition) for unit testing. This is stricter
in that messages must be addressed and deprecated functions throw errors.
(#230)
- Slight boost to test coverage for `dev_utilities` (#102)
- Fix datatable styling for documentation (#197)
- The `assert_character_vector()` function gained a `named` argument to check
that all elements of the vector are named. (#70)
- The `assert_list_of()` function gained a `named` argument to check that all
elements of the list are named. (#203)
- The `quote_fun` argument of `enumerate()` was extended such that `NULL` can
be specified to request no quoting of the elements. (#203)
- The `assert_list_of()` function was enhanced such that it also considers the
type of the element, e.g., to check if a value is a list of symbols. (#208)

## Breaking Changes
- The default value of the `optional` argument in `assert_date_vector()`,
`assert_list_of()`, and `assert_s3_class()` was changed from `TRUE` to `FALSE`
to make the default behavior consistent. (#87)
- admiral functions no longer expect list of quosures created by `vars()` but
list of expressions created by `exprs()`. Thus the following functions and
arguments were deprecated:
- `quo_c()` and `replace_symbol_in_quo()`
- the `quosures` argument in `get_source_vars()`,
`replace_values_by_names()`, and `vars2chr()`

## Documentation
- New section in programming strategy regarding comments (#71)
- Removed requirement to add `@author` tags to code scripts from programming
strategy, as we will only be tracking authors in the DESCRIPTION file. Authors
have been removed from function documentation in line with this update.
(#206, #210)
- Removed On-boarding Issue Template (#225)
- Increased clarity for the scope of the package (#232)

# admiraldev 0.2.0

## New Features
Expand All @@ -22,7 +63,7 @@
- New vignette for our package release strategy (#79)
- Updated multiple roxygen headers (#116, #133, #134, #141, #145, #172)
- Description on how admiral options work for certain function inputs, i.e `subject_keys` (#133)

## Various
- PR Checklist Template updated (#172)
- New authors/contributors (#158)
Expand Down
23 changes: 11 additions & 12 deletions R/admiraldev-package.R
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
#' @keywords internal
#' @importFrom dplyr arrange bind_rows case_when desc ends_with filter full_join group_by
#' if_else mutate mutate_at mutate_if n pull rename rename_at row_number select slice
#' starts_with transmute ungroup vars n_distinct union distinct
#' summarise_at summarise coalesce bind_cols na_if tibble
#' @importFrom dplyr across arrange bind_rows case_when desc ends_with filter
#' full_join group_by if_else mutate n pull rename row_number select slice
#' starts_with transmute ungroup n_distinct union distinct summarise coalesce
#' bind_cols na_if tibble
#' @importFrom magrittr %>%
#' @importFrom rlang := abort arg_match as_function as_label as_string call2 caller_env
#' call_name current_env .data enexpr enquo eval_bare eval_tidy expr
#' expr_interp expr_label f_lhs f_rhs inform missing_arg
#' is_bare_formula is_call is_character is_formula is_integerish
#' is_logical is_quosure is_quosures is_symbol new_formula
#' parse_expr parse_exprs quo quo_get_expr quo_is_call
#' quo_is_missing quo_is_null quo_is_symbol quos quo_squash quo_text
#' set_names sym syms type_of warn quo_set_env quo_get_env
#' @importFrom rlang := abort arg_match as_function as_label as_name as_string
#' call2 caller_env call_name current_env .data enexpr enquo eval_bare
#' eval_tidy expr expr_interp expr_label exprs f_lhs f_rhs inform missing_arg
#' is_bare_formula is_call is_character is_expression is_formula is_integerish
#' is_logical is_missing is_quosure is_symbol is_symbolic new_formula
#' parse_expr parse_exprs quo quo_is_missing quo_is_null set_names sym syms
#' type_of warn
#' @importFrom utils capture.output str
#' @importFrom purrr map map2 map_chr map_lgl reduce walk keep map_if transpose
#' flatten every modify_at modify_if reduce compose
Expand Down
Loading

0 comments on commit c0a814e

Please sign in to comment.