Add devel image #165
Add devel image #165
Conversation
| @@ -365,13 +365,18 @@ jobs: | |||
| id: branch | |||
| run: | | |||
| repo_name=$(basename "${{ github.repository }}") | |||
| echo "source-branch=${{ env.source-branch }}_${repo_name}@devel" >> $GITHUB_OUTPUT | |||
| source_br="${{ env.source-branch }}_${repo_name}@devel" | |||
There was a problem hiding this comment.
@cicdguy : since this PR includes several changes I just add some comments ! here I added this change for pharmaverseadam datasets creation (since we push updates to a new branch, I just make a check before to see if the branch exists - if not we do not trigger the "commit and push changes" step (then we avoid error cases that we often have since pharmaverseadam maintainers might sometimes forget to merge some pending PRs..)
I also thought creating unique branch but would be super messy I guess
There was a problem hiding this comment.
Good call.
BTW you do not need the @devel suffix anymore for the branch names since everything now uses main as the default branch
There was a problem hiding this comment.
Oh yes indeed you're right :) just from some old runs I guess I just forgot to delete it 🙈
| @@ -94,5 +94,41 @@ jobs: | |||
| repo-user: ${{ github.actor }} # pharmaverse-bot | |||
| repo-token: "${{ secrets.GITHUB_TOKEN }}" # ${{ secrets.PHARMAVERSE_BOT }} | |||
|
|
|||
| deploy-image-devel: | |||
There was a problem hiding this comment.
Add step to deploy devel image
| - name: Check Version | ||
| id: check_version | ||
| run: | | ||
| maintenance_version="F" |
There was a problem hiding this comment.
Here this is a step to check if version has this pattern x.y.x.m with m >= 9000 - if this is the case then on next step we are doing this : Sys.setenv("R_CHECK_CRAN_INCOMING_SKIP_LARGE_VERSION" = TRUE) to avoid having notes on rcmdchecks
There was a problem hiding this comment.
I'd recommend just setting this as a top-level environment var instead of a session-specific var.
There was a problem hiding this comment.
ah sure? (because I see this more like temp setup to just enable checks in case of dev version) - but np to change this !
There was a problem hiding this comment.
No, never mind. Your implementation should work. Keep it as-is.
oh actually.. I just forgot to set up the cronjob for docker devel, let me add this little change ! (feel free to disapprove 😂 ) |
|
@cicdguy I am afraid .. I became a bot .. |
|
Deep inside, we're all bots @dgrassellyb |
Closes #155 #154 #146 #31 (duplicate of 154..)
(also some updates related to #159 : checking if branch exists - but still ongoing discussions / potential updates for this issue..)