Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #154 devel check #156

Closed
wants to merge 2 commits into from
Closed

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Oct 9, 2023

No description provided.

@bms63 bms63 requested a review from cicdguy as a code owner October 9, 2023 14:21
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Code Coverage

Package Line Rate Health
admiralci 0%
Summary 0% (0 / 22)

@bms63 bms63 linked an issue Oct 9, 2023 that may be closed by this pull request
@bms63
Copy link
Collaborator Author

bms63 commented Oct 9, 2023

@cicdguy @galachad @dgrassellyb @ddsjoberg does something else need to happen with the containers to allow me to add an additional rcmd check?

Also was hoping to add a windows check as this one has caused us some problems.

@bms63
Copy link
Collaborator Author

bms63 commented Oct 9, 2023

image

@cicdguy
Copy link
Collaborator

cicdguy commented Oct 11, 2023

There is no container that matches that tag. What are you expecting, exactly @bms63?

@bms63
Copy link
Collaborator Author

bms63 commented Oct 11, 2023

I was hoping that we could run on the development version of R - 4.4 before it gets released.

Also possible to run a check on windows?

@cicdguy
Copy link
Collaborator

cicdguy commented Oct 11, 2023

I was hoping that we could run on the development version of R - 4.4 before it gets released.

We'll need to create a container for this.

Also possible to run a check on windows?

Again, container or separate workflow needed for this too.

@dgrassellyb
Copy link
Collaborator

@bms63 could we close this one ?

@bms63
Copy link
Collaborator Author

bms63 commented Dec 1, 2023

Yes!!

@bms63 bms63 closed this Dec 1, 2023
@cicdguy cicdguy deleted the 154-do-we-not-run-r-cmd-check-on-devel branch February 20, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we not run R CMD Check on devel?
3 participants