Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #143 and modifies #139 for removal of admiral.test and adding pharmaverse sdtm #144

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Closes #143 and modifies #139 for removal of admiral.test and adding pharmaverse sdtm #144

merged 7 commits into from
Sep 21, 2023

Conversation

zdz2101
Copy link
Collaborator

@zdz2101 zdz2101 commented Aug 25, 2023

No description provided.

@zdz2101 zdz2101 requested a review from galachad August 25, 2023 15:18
@zdz2101
Copy link
Collaborator Author

zdz2101 commented Aug 25, 2023

@galachad in addition to your pre-existing PR can we remove admiral.test as well? I was blocked from making changes to .github/workflows/r-renv-lock.yml but I think it would need to be made there as well? tagging @bms63 to stay in the loop

@zdz2101 zdz2101 marked this pull request as ready for review August 25, 2023 15:21
@zdz2101 zdz2101 requested a review from cicdguy as a code owner August 25, 2023 15:21
cicdguy
cicdguy approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zdz2101

Base automatically changed from 139_replace_admiral.test to main September 21, 2023 09:56
@github-actions
Copy link

Code Coverage

Package Line Rate Health
admiralci 0% ❌
Summary 0% (0 / 22) ❌

@zdz2101 zdz2101 linked an issue Sep 21, 2023 that may be closed by this pull request
Remove admiral.test from renv and .Rprofile #143
Closed
@galachad galachad merged commit cd95618 into main Sep 21, 2023
25 checks passed
@galachad galachad deleted the 143-remove-admiraltest-from-renv-and-rprofile branch September 21, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdguy cicdguy cicdguy approved these changes

@galachad galachad Awaiting requested review from galachad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove admiral.test from renv and .Rprofile
3 participants
@zdz2101 @cicdguy @galachad