Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2563 no_list_columns: filter before check #2611

Merged
merged 13 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/derive_vars_transposed.R
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ derive_vars_transposed <- function(dataset,
optional = TRUE
)

dataset_merge <- filter_if(dataset_merge, filter)

# check for duplicates in dataset_merge as these will create list columns,
# which is not acceptable for ADaM datasets
signal_duplicate_records(
Expand All @@ -134,7 +136,6 @@ derive_vars_transposed <- function(dataset,
)

dataset_transposed <- dataset_merge %>%
filter_if(filter) %>%
pivot_wider(
names_from = !!key_var,
values_from = !!value_var,
Expand Down
9 changes: 9 additions & 0 deletions tests/testthat/test-derive_vars_transposed.R
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ test_that("derive_vars_transposed Test 2: filtering the merge dataset works", {
"STUDY01", "P02", 31, 3,
"STUDY01", "P03", 42, NA
)

dataset_merge <- tibble::tribble(
~STUDYID, ~USUBJID, ~TESTCD, ~VALUE,
"STUDY01", "P01", "T01", 31,
"STUDY01", "P01", "T02", 5,
"STUDY01", "P02", "T01", 3,
"STUDY01", "P01", "T02", 9
)

actual_output <- derive_vars_transposed(
dataset,
dataset_merge,
Expand Down
Loading