-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1839 dummy function created #2474
Conversation
Great job @Siddhesh2097 - looks almost perfect, just two outstanding tasks: |
@Siddhesh2097 looks good now! If you check every item in the tasklist then the final check should pass as well, then you are good to go! |
Thank You @manciniedoardo. I have checked all items and the final check has passed. I clicked on Ready for Review. Can you tell me the next step, whether I need to close this issue or it will done by you. |
@Siddhesh2097 all good now - i will close this PR now and you can start working on admiralmetabolic! |
@Siddhesh2097 can I add you to the admiral community team? We ping this team occasionally on admiral developments? It is pretty low engagement ( a couple pings a month at most) |
@bms63 Sure, please add me |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF version of it to the same folder.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()