-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes # 1839 dummy function created #2209
Conversation
@pharmaverse/admiral |
We need some documentation - use devtools::document We need an entry in the news Try rendering the pkgdown site Use #1839 in your commit message. It becomes a link! way cool! You no longer need Don't use anything gsk-related on GitHub - You should take out your id. Run styler on your code Check out how we style our tests - try out the addin |
Hi @Sreegunachinnapareddygari - can you make these updates to your PR. If you don't have the time, then I would like to close this PR as I like to keep our PR queue tidy. |
Hi Ben,
I will work on this tomorrow for sure as I was busy with my study timelines
until today.
Sorry for the delay.
Thanks,
Sree
…On Tue, 14 Nov 2023, 18:19 Ben Straub, ***@***.***> wrote:
Hi @Sreegunachinnapareddygari
<https://github.com/Sreegunachinnapareddygari> - can you make these
updates to your PR. If you don't have the time, then I would like to close
this PR as I like to keep our PR queue tidy.
—
Reply to this email directly, view it on GitHub
<#2209 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDFO3AGYYXEN4CIE6W7EBRDYEOYZTAVCNFSM6AAAAAA6XWNHISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQHA3TENBUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi Ben, I am facing issues with desktop R studio. I tried uninstalling the previous one and install again. But no luck. For some reason, it is failed to open now. Need some ones help and I am not very sure about few updates which you have asked me do. I can check with Gayatri, but she is on annual leave until this Friday. If someone helps me on this, that would be great. Thanks, |
Hi @Sreeguna any luck with your R? Going to close this PR as it is a bit old. Feel free to start a new one when you are back in action. |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()