Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes # 1839 dummy function created #2209

Closed
wants to merge 3 commits into from

Conversation

Sreegunachinnapareddygari
Copy link

@Sreegunachinnapareddygari Sreegunachinnapareddygari commented Oct 31, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@Sreegunachinnapareddygari Sreegunachinnapareddygari linked an issue Oct 31, 2023 that may be closed by this pull request
@Sreegunachinnapareddygari
Copy link
Author

@pharmaverse/admiral

@bms63
Copy link
Collaborator

bms63 commented Nov 2, 2023

We need some documentation - use devtools::document

We need an entry in the news

Try rendering the pkgdown site

Use #1839 in your commit message. It becomes a link! way cool!

You no longer need @devel for your branch.

Don't use anything gsk-related on GitHub - You should take out your id.

Run styler on your code

Check out how we style our tests - try out the addin

@bms63
Copy link
Collaborator

bms63 commented Nov 14, 2023

Hi @Sreegunachinnapareddygari - can you make these updates to your PR. If you don't have the time, then I would like to close this PR as I like to keep our PR queue tidy.

@Sreegunachinnapareddygari
Copy link
Author

@Sreegunachinnapareddygari
Copy link
Author

Hi Ben, I will work on this tomorrow for sure as I was busy with my study timelines until today. Sorry for the delay. Thanks, Sree

On Tue, 14 Nov 2023, 18:19 Ben Straub, @.> wrote: Hi @Sreegunachinnapareddygari https://github.com/Sreegunachinnapareddygari - can you make these updates to your PR. If you don't have the time, then I would like to close this PR as I like to keep our PR queue tidy. — Reply to this email directly, view it on GitHub <#2209 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDFO3AGYYXEN4CIE6W7EBRDYEOYZTAVCNFSM6AAAAAA6XWNHISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQHA3TENBUHA . You are receiving this because you were mentioned.Message ID: @.>

Hi Ben, I will work on this tomorrow for sure as I was busy with my study timelines until today. Sorry for the delay. Thanks, Sree

On Tue, 14 Nov 2023, 18:19 Ben Straub, @.> wrote: Hi @Sreegunachinnapareddygari https://github.com/Sreegunachinnapareddygari - can you make these updates to your PR. If you don't have the time, then I would like to close this PR as I like to keep our PR queue tidy. — Reply to this email directly, view it on GitHub <#2209 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDFO3AGYYXEN4CIE6W7EBRDYEOYZTAVCNFSM6AAAAAA6XWNHISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQHA3TENBUHA . You are receiving this because you were mentioned.Message ID: @.>

Hi Ben,

I am facing issues with desktop R studio. I tried uninstalling the previous one and install again. But no luck. For some reason, it is failed to open now. Need some ones help and I am not very sure about few updates which you have asked me do. I can check with Gayatri, but she is on annual leave until this Friday. If someone helps me on this, that would be great.

Thanks,
Sree

@bms63
Copy link
Collaborator

bms63 commented Nov 28, 2023

Hi @Sreeguna any luck with your R? Going to close this PR as it is a bit old. Feel free to start a new one when you are back in action.

@bms63 bms63 closed this Nov 28, 2023
@bms63 bms63 deleted the 1839_dummy_sc@devel branch February 5, 2024 16:58
@bms63 bms63 removed a link to an issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants