Skip to content

Commit

Permalink
fix: wrong window names
Browse files Browse the repository at this point in the history
  • Loading branch information
maximgeerinck committed Jun 8, 2023
1 parent be1b371 commit cf7e85e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion commands/metamask.js
Original file line number Diff line number Diff line change
Expand Up @@ -1198,7 +1198,7 @@ const metamask = {
// log('[confirmTransaction] Checking if tx data is present..');
// if (
// await playwright
// .notificationwindows(PROVIDER)
// .windows(PROVIDER)
// .locator(confirmPageElements.dataButton)
// .count() > 0
// ) {
Expand Down
13 changes: 6 additions & 7 deletions helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,12 @@ module.exports = {
log(
`Trying to download and extract file from: ${url} to following path: ${destination}`,
);

if (provider === 'phantom') {
// phantom doesnt support downloading yet.
return;
}

if (process.env.GH_USERNAME && process.env.GH_PAT) {
await download(url, destination, {
extract: true,
Expand All @@ -277,13 +283,6 @@ module.exports = {
Accept: 'application/octet-stream',
},
});

/**
* Some extensions will zip their dist folder
*/
if (provider === 'phantom') {
await moveFiles(`${destination}/dist`, destination);
}
} else {
await download(url, destination, {
extract: true,
Expand Down

0 comments on commit cf7e85e

Please sign in to comment.