Fixed string constructor

pgvector · Oct 21, 2023 · 8da4b87 · 8da4b87
1 parent 90c2681
commit 8da4b87
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Pgvector/Vector.cs b/src/Pgvector/Vector.cs
@@ -12,7 +12,7 @@ public Vector(ReadOnlyMemory<float> v)
         => Memory = v;
 
     public Vector(string s)
-        => new Vector(Array.ConvertAll(s.Substring(1, s.Length - 2).Split(','), v => float.Parse(v, CultureInfo.InvariantCulture)));
+        => Memory = Array.ConvertAll(s.Substring(1, s.Length - 2).Split(','), v => float.Parse(v, CultureInfo.InvariantCulture));
 
     public override string ToString()
         => string.Concat("[", string.Join(",", Memory.ToArray().Select(v => v.ToString(CultureInfo.InvariantCulture))), "]");

diff --git a/tests/Pgvector.Tests/VectorTests.cs b/tests/Pgvector.Tests/VectorTests.cs
@@ -4,6 +4,13 @@ namespace Pgvector.Tests;
 
 public class VectorTests
 {
+    [Fact]
+    public void StringConstructor()
+    {
+        var v = new Vector("[1,2,3]");
+        Assert.Equal("[1,2,3]", v.ToString());
+    }
+
     [Fact]
     public void Equal()
     {