forked from PicnicSupermarket/dbt-score
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Only output failing models and violated rules per default in HumanRea…
…dableFormatter (PicnicSupermarket#77) Fixes PicnicSupermarket#71 It changes the default behavior of the HumanReadableFormatter: When running `dbt-score lint` it will now only show failing models and/or rules which were violated. To have all output printed (exactly the way it was before this PR) the user has now to pass the `--show_all` flag to `dbt-score lint`. It also considers the `fail_any_model_under` option. Furthermore, I had to adjust some of tests since the default behavior of the HumanReadableFormatter is now changed - let me know if I would need to expand this. The docs also reflect this change by slightly tweaking the first example in `index.md` In this current form, both rule violations and failing models are filtered through the same argument. This is based on @matthieucan. 's comment on PicnicSupermarket#71 (comment) --------- Co-authored-by: Jochem van Dooren <[email protected]> Co-authored-by: Matthieu Caneill <[email protected]>
- Loading branch information
1 parent
9f6aa67
commit c8a7d27
Showing
7 changed files
with
120 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters