refactoring_optim_fix (#150)

* fix ci * fix nullable object
pfh59 · Oct 17, 2023 · df6dc02 · df6dc02
1 parent 9ea5b9a
commit df6dc02
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/.github/workflows/ci-cd.yaml b/.github/workflows/ci-cd.yaml
@@ -47,7 +47,7 @@ jobs:
           time: '5s'
 
       - name: Restore dependencies
-        run: dotnet restore 
+        run: dotnet restore src
 
       - name: Cache SonarCloud packages
         uses: actions/cache@v1

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -0,0 +1,6 @@
+{
+    "sonarlint.connectedMode.project": {
+        "connectionId": "vscode",
+        "projectKey": "pfh59_eve-whmapper"
+    }
+}
diff --git a/src/WHMapper/Pages/Mapper/CustomNode/EveSystemNode.razor b/src/WHMapper/Pages/Mapper/CustomNode/EveSystemNode.razor
@@ -28,9 +28,12 @@
                             </ChildContent>
                             <TooltipContent>
                                 <MudPaper Class="d-flex flex-column flex-grow-1 gap-1" Elevation="0">
-                                    @foreach (var effectInfo in Node.EffectDetails)
+                                    @if (Node != null && Node.EffectDetails!=null)
                                     {
-                                        <MudText class="ml-1 mr-1" Typo="Typo.caption">@effectInfo.Name. : @effectInfo.Value%</MudText>
+                                        foreach (var effectInfo in Node.EffectDetails)
+                                        {
+                                            <MudText class="ml-1 mr-1" Typo="Typo.caption">@effectInfo.Name. : @effectInfo.Value%</MudText>
+                                        }
                                     }
                                 </MudPaper>
                             </TooltipContent>
@@ -61,7 +64,7 @@
                     {
                         <MudIcon Icon="@Icons.Material.Filled.Group" Color=Color.Transparent Size="Size.Small" />
                     }
-                    <MudText Class="align-self-stretch ml-1 mt-1" Typo="Typo.caption">@Node?.ConnectedUsers.FirstOrDefault()</MudText>
+                    <MudText Class="align-self-stretch ml-1 mt-1" Typo="Typo.caption">@Node?.ConnectedUsers?.FirstOrDefault()</MudText>
                 </div>
                 <div Class="d-flex justify-end">
                     @if (Node != null && Node.Statics != null && Node?.Statics.Count() > 0)