Add refresh visit action

pfeiffer · Feb 15, 2024 · 1fcc039 · 1fcc039
1 parent fccb3a4
commit 1fcc039
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/src/core/drive/page_view.js b/src/core/drive/page_view.js
@@ -16,7 +16,7 @@ export class PageView extends View {
   }
 
   renderPage(snapshot, isPreview = false, willRender = true, visit) {
-    const shouldMorphPage = this.isPageRefresh(visit) && this.snapshot.shouldMorphPage
+    const shouldMorphPage = this.isMorphable(visit) && this.snapshot.shouldMorphPage
     const rendererClass = shouldMorphPage ? MorphRenderer : PageRenderer
 
     const renderer = new rendererClass(this.snapshot, snapshot, PageRenderer.renderElement, isPreview, willRender)
@@ -55,12 +55,20 @@ export class PageView extends View {
     return this.snapshotCache.get(location)
   }
 
-  isPageRefresh(visit) {
+  isReplacingSamePage(visit) {
     return !visit || (this.lastRenderedLocation.pathname === visit.location.pathname && visit.action === "replace")
   }
 
+  isRefreshing(visit) {
+    return visit && visit.action === "refresh"
+  }
+
+  isMorphable(visit) {
+    return this.isRefreshing(visit) || this.isReplacingSamePage(visit)
+  }
+
   shouldPreserveScrollPosition(visit) {
-    return this.isPageRefresh(visit) && this.snapshot.shouldPreserveScrollPosition
+    return this.isMorphable(visit) && this.snapshot.shouldPreserveScrollPosition
   }
 
   get snapshot() {

diff --git a/src/core/drive/visit.js b/src/core/drive/visit.js
@@ -39,7 +39,8 @@ export const SystemStatusCode = {
 export const Direction = {
   advance: "forward",
   restore: "back",
-  replace: "none"
+  replace: "none",
+  refresh: "none"
 }
 
 export class Visit {
@@ -389,6 +390,7 @@ export class Visit {
   getHistoryMethodForAction(action) {
     switch (action) {
       case "replace":
+      case "refresh":
         return history.replaceState
       case "advance":
       case "restore":

diff --git a/src/core/index.js b/src/core/index.js
@@ -33,7 +33,7 @@ export function registerAdapter(adapter) {
  * @param location Location to visit (a URL or path)
  * @param options Options to apply
  * @param options.action Type of history navigation to apply ("restore",
- * "replace" or "advance")
+ * "replace", "refresh" or "advance")
  * @param options.historyChanged Specifies whether the browser history has
  * already been changed for this visit or not
  * @param options.referrer Specifies the referrer of this visit such that

diff --git a/src/core/session.js b/src/core/session.js
@@ -111,7 +111,7 @@ export class Session {
     const isRecentRequest = requestId && this.recentRequests.has(requestId)
     if (!isRecentRequest) {
       this.cache.exemptPageFromPreview()
-      this.visit(url, { action: "replace" })
+      this.visit(url, { action: "refresh" })
     }
   }