Fix undefined behavior leading to crash with clang #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code crashes with clang 3.4.1+, most likely due to arithmetics to null pointer, which is undefined behavior
|
PPPS. I've just realized you may not be catdoc author. Still, fixes are relevant. |
This was referenced May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code crashes with clang 3.4.1+, most likely due to arithmetics to null pointer, which is undefined behavior. I've fixed two apparent cases, there may be more.
PS. I'll be unavailable for 2 weeks, after that I'll try to find other cases.
PPS. FYI, there's bunch of other code fixes to catdoc in Debian, you'd probably like to review and merge them as well. Catdoc it still in high demand, and I really hope we can bring it back to shape.