maybe fixed eof bug

Signed-off-by: Peter Alfonsi <[email protected]>
peteralfonsi · Dec 12, 2024 · 5da2a70 · 5da2a70
1 parent 5999e92
commit 5da2a70
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/server/src/main/java/org/opensearch/indices/query/PluggableQueryCache.java b/server/src/main/java/org/opensearch/indices/query/PluggableQueryCache.java
@@ -892,8 +892,8 @@ private void serializeDocIdSet(DocIdSet set, BytesStreamOutput os) {
                     nextDoc = iterator.nextDoc();
                     os.writeVInt(nextDoc);
                 }
-                os.writeVInt(NO_MORE_DOCS);
-                os.writeVInt(0); // Spare value for deserializer to read, to spare us from checking if nextDoc == NO_MORE_DOCS on every read
+                //os.writeVInt(NO_MORE_DOCS);
+                //os.writeVInt(0); // Spare value for deserializer to read, to spare us from checking if nextDoc == NO_MORE_DOCS on every read
             } catch (IOException e) {
                 throw new OpenSearchException("Error iterating through DocSetIdIterator", e);
             }
@@ -914,7 +914,7 @@ private DocIdSet deserializeDocIdSet(BytesStreamInput is, int maxDoc) {
                     int bitSetLength = 0;
                     while (nextDoc != NO_MORE_DOCS) {
                         bitset.set(nextDoc);
-                        nextDoc = is.readVInt();
+                        nextDoc = is.readVInt(); // TODO: Was getting EOF here.
                         bitSetLength++;
                     }
                     return new BitDocIdSet(bitset, bitSetLength); // TODO: I *think* bitSetLength is the correct value for cost.