feat: list verification pipeline v1 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ulydev
approved these changes
Aug 20, 2024
| "underlying": { | ||
| "type": "string", | ||
| "pattern": "^0x[a-fA-F0-9]{40}$" | ||
| }, |
There was a problem hiding this comment.
Suggested change
| }, | |
| }, "externalLink": { "type": "string", "pattern": "https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*)" }, |
Can we add this extension: externalLink 🙏
There was a problem hiding this comment.
we have the externalLink already (line 48) but I will extend it by the pattern
There was a problem hiding this comment.
I had to change the regex and provided one doesn't work for our current value
matstyler
force-pushed
the
feat/list-verification-pipeline
branch
2 times, most recently
from
4d32f48 to
45eb00f
Compare
matstyler
force-pushed
the
feat/list-verification-pipeline
branch
from
45eb00f to
18964a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.