Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move c value bounds to per-chain params #732

Merged
merged 17 commits into from
Jan 22, 2024
Merged

Conversation

kruspy
Copy link
Collaborator

@kruspy kruspy commented Jan 22, 2024

No description provided.

@kruspy kruspy requested a review from a team as a code owner January 22, 2024 07:52

This comment has been minimized.

Copy link

Coverage after merging fix/per-chain-c-value into main

70.00%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstake/keeper
   grpc_query.go100%100%100%
   genesis.go100%100%86.96%14, 23, 32
   keeper.go100%100%77.50%..., 92, 95, 96, 97
   liquidstake.go100%100%61.61%..., 647, 92, 93, 99
   rebalancing.go100%100%93.33%..., 45, 46, 81, 82
x/liquidstake/types
   genesis.go100%100%100%
   rebalancing.go100%100%84%22, 23, 40, 41
   params.go100%100%83.19%..., 195, 196, 87, 88
   msgs.go100%100%40.58%..., 96, 97, 98, 99
   liquidstake.go100%100%93.57%..., 63, 64, 73, 81
   codec.go100%100%100%
   keys.go100%100%100%
x/liquidstakeibc
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
   genesis.go100%100%100%
   module.go100%100%56.10%..., 96, 97, 98, 99
x/liquidstakeibc/keeper
   delegation_strategy.go100%100%100%
   ica_handlers.go100%100%29.18%..., 96, 97, 98, 99
   redelegation.go100%100%100%
   msg_server.go100%100%61.08%..., 963, 964, 967, 968
   host_chain.go100%100%99.64%129
   invariants.go100%100%100%
   redelegation_txs.go100%100%100%
   icq_queries.go100%100%80%..., 144, 145, 146, 147
   ica.go100%100%65%..., 70, 71, 72, 73
   rebalance.go100%100%91.21%..., 115, 116, 77, 80
   user_unbonding.go100%100%100%
   validator_unbonding.go100%100%100%
   deposit.go100%100%99.02%87, 88
   grpc_querier.go100%100%95.17%..., 310, 311, 319, 320
   icq.go100%100%75.90%..., 233, 43, 44, 45
   migrations.go100%100%33.33%..., 23, 26, 27, 28
   hooks.go100%100%42.18%..., 909, 910, 944, 945
   ibc.go100%100%23.66%..., 93, 94, 95, 96
   unbonding.go100%100%100%
   abci.go100%100%74.63%..., 83, 84, 85, 86
   keeper.go100%100%96.80%..., 366, 374, 93, 94
   lsm_deposit.go100%100%100%
x/liquidstakeibc/types
   liquidstakeibc.go100%100%97.83%17, 18, 19
   hooks.go100%100%0%..., 29, 30, 31, 34
   msgs.go100%100%86.32%..., 380, 381, 482, 483
   codec.go100%100%100%
   params.go100%100%100%
   host_chain.go100%100%100%
   keys.go100%100%0%..., 122, 96, 97, 98
   genesis.go100%100%100%
x/ratesync
   module.go100%100%64.06%..., 80, 83, 84, 85
   module_simulation.go100%100%0%..., 79, 80, 81, 82
   genesis.go100%100%100%
   module_ibc.go100%100%9.09%..., 96, 97, 98, 99
x/ratesync/keeper
   query.go100%100%85.71%..., 40, 41, 47, 48
   ibc.go100%100%67.09%..., 55, 67, 68, 69
   ica_tx.go100%100%71.53%..., 83, 84, 85, 86
   params.go100%100%84.62%14, 15
   chain.go100%100%100%
   abci.go100%100%95.65%36
   hooks.go100%100%87.76%..., 27, 28, 68, 69
   keeper.go100%100%78.38%..., 80, 81, 88, 89
   msg_server.go100%100%74.91%..., 63, 64, 65, 66
x/ratesync/types
   types.go100%100%96.36%..., 128, 129, 28, 29
   msgs.go100%100%67.94%..., 66, 79, 96, 97
   genesis.go100%100%100%
   codec.go100%100%0%..., 26, 27, 28, 29
   params.go100%100%75%31, 32, 33, 34
   keys.go100%100%100%

app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
Copy link

Coverage after merging fix/per-chain-c-value into main

70.00%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstake/keeper
   grpc_query.go100%100%100%
   keeper.go100%100%77.50%..., 92, 95, 96, 97
   liquidstake.go100%100%61.61%..., 647, 92, 93, 99
   genesis.go100%100%86.96%14, 23, 32
   rebalancing.go100%100%93.33%..., 45, 46, 81, 82
x/liquidstake/types
   codec.go100%100%100%
   liquidstake.go100%100%93.57%..., 63, 64, 73, 81
   msgs.go100%100%40.58%..., 96, 97, 98, 99
   rebalancing.go100%100%84%22, 23, 40, 41
   keys.go100%100%100%
   params.go100%100%83.19%..., 195, 196, 87, 88
   genesis.go100%100%100%
x/liquidstakeibc
   module.go100%100%56.10%..., 96, 97, 98, 99
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
   genesis.go100%100%100%
x/liquidstakeibc/keeper
   grpc_querier.go100%100%95.17%..., 310, 311, 319, 320
   user_unbonding.go100%100%100%
   icq.go100%100%75.90%..., 233, 43, 44, 45
   redelegation_txs.go100%100%100%
   abci.go100%100%74.63%..., 83, 84, 85, 86
   delegation_strategy.go100%100%100%
   ica_handlers.go100%100%29.18%..., 96, 97, 98, 99
   validator_unbonding.go100%100%100%
   ibc.go100%100%23.66%..., 93, 94, 95, 96
   ica.go100%100%65%..., 70, 71, 72, 73
   unbonding.go100%100%100%
   icq_queries.go100%100%80%..., 144, 145, 146, 147
   rebalance.go100%100%91.21%..., 115, 116, 77, 80
   keeper.go100%100%96.80%..., 366, 374, 93, 94
   migrations.go100%100%33.33%..., 23, 26, 27, 28
   invariants.go100%100%100%
   deposit.go100%100%99.02%87, 88
   hooks.go100%100%42.18%..., 909, 910, 944, 945
   msg_server.go100%100%61.08%..., 963, 964, 967, 968
   redelegation.go100%100%100%
   host_chain.go100%100%99.64%129
   lsm_deposit.go100%100%100%
x/liquidstakeibc/types
   hooks.go100%100%0%..., 29, 30, 31, 34
   params.go100%100%100%
   codec.go100%100%100%
   genesis.go100%100%100%
   host_chain.go100%100%100%
   msgs.go100%100%86.32%..., 380, 381, 482, 483
   liquidstakeibc.go100%100%97.83%17, 18, 19
   keys.go100%100%0%..., 122, 96, 97, 98
x/ratesync
   module_simulation.go100%100%0%..., 79, 80, 81, 82
   module_ibc.go100%100%9.09%..., 96, 97, 98, 99
   module.go100%100%64.06%..., 80, 83, 84, 85
   genesis.go100%100%100%
x/ratesync/keeper
   params.go100%100%84.62%14, 15
   ibc.go100%100%67.09%..., 55, 67, 68, 69
   query.go100%100%85.71%..., 40, 41, 47, 48
   msg_server.go100%100%74.91%..., 63, 64, 65, 66
   abci.go100%100%95.65%36
   keeper.go100%100%78.38%..., 80, 81, 88, 89
   hooks.go100%100%87.76%..., 27, 28, 68, 69
   chain.go100%100%100%
   ica_tx.go100%100%71.53%..., 83, 84, 85, 86
x/ratesync/types
   keys.go100%100%100%
   types.go100%100%96.36%..., 128, 129, 28, 29
   params.go100%100%75%31, 32, 33, 34
   msgs.go100%100%67.94%..., 66, 79, 96, 97
   genesis.go100%100%100%
   codec.go100%100%0%..., 26, 27, 28, 29

Copy link

Coverage after merging fix/per-chain-c-value into main

70.00%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstake/keeper
   genesis.go100%100%86.96%14, 23, 32
   rebalancing.go100%100%93.33%..., 45, 46, 81, 82
   grpc_query.go100%100%100%
   liquidstake.go100%100%61.61%..., 647, 92, 93, 99
   keeper.go100%100%77.50%..., 92, 95, 96, 97
x/liquidstake/types
   codec.go100%100%100%
   liquidstake.go100%100%93.57%..., 63, 64, 73, 81
   genesis.go100%100%100%
   keys.go100%100%100%
   rebalancing.go100%100%84%22, 23, 40, 41
   params.go100%100%83.19%..., 195, 196, 87, 88
   msgs.go100%100%40.58%..., 96, 97, 98, 99
x/liquidstakeibc
   module.go100%100%56.10%..., 96, 97, 98, 99
   genesis.go100%100%100%
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
x/liquidstakeibc/keeper
   migrations.go100%100%33.33%..., 23, 26, 27, 28
   delegation_strategy.go100%100%100%
   msg_server.go100%100%61.08%..., 963, 964, 967, 968
   ica_handlers.go100%100%29.18%..., 96, 97, 98, 99
   keeper.go100%100%96.80%..., 366, 374, 93, 94
   unbonding.go100%100%100%
   deposit.go100%100%99.02%87, 88
   redelegation.go100%100%100%
   ica.go100%100%65%..., 70, 71, 72, 73
   rebalance.go100%100%91.21%..., 115, 116, 77, 80
   user_unbonding.go100%100%100%
   host_chain.go100%100%99.64%129
   icq_queries.go100%100%80%..., 144, 145, 146, 147
   hooks.go100%100%42.18%..., 909, 910, 944, 945
   ibc.go100%100%23.66%..., 93, 94, 95, 96
   lsm_deposit.go100%100%100%
   icq.go100%100%75.90%..., 233, 43, 44, 45
   abci.go100%100%74.63%..., 83, 84, 85, 86
   grpc_querier.go100%100%95.17%..., 310, 311, 319, 320
   validator_unbonding.go100%100%100%
   invariants.go100%100%100%
   redelegation_txs.go100%100%100%
x/liquidstakeibc/types
   params.go100%100%100%
   codec.go100%100%100%
   hooks.go100%100%0%..., 29, 30, 31, 34
   liquidstakeibc.go100%100%97.83%17, 18, 19
   msgs.go100%100%86.32%..., 380, 381, 482, 483
   genesis.go100%100%100%
   host_chain.go100%100%100%
   keys.go100%100%0%..., 122, 96, 97, 98
x/ratesync
   module_simulation.go100%100%0%..., 79, 80, 81, 82
   module_ibc.go100%100%9.09%..., 96, 97, 98, 99
   genesis.go100%100%100%
   module.go100%100%64.06%..., 80, 83, 84, 85
x/ratesync/keeper
   ica_tx.go100%100%71.53%..., 83, 84, 85, 86
   query.go100%100%85.71%..., 40, 41, 47, 48
   params.go100%100%84.62%14, 15
   keeper.go100%100%78.38%..., 80, 81, 88, 89
   msg_server.go100%100%74.91%..., 63, 64, 65, 66
   chain.go100%100%100%
   hooks.go100%100%87.76%..., 27, 28, 68, 69
   ibc.go100%100%67.09%..., 55, 67, 68, 69
   abci.go100%100%95.65%36
x/ratesync/types
   keys.go100%100%100%
   params.go100%100%75%31, 32, 33, 34
   types.go100%100%96.36%..., 128, 129, 28, 29
   codec.go100%100%0%..., 26, 27, 28, 29
   genesis.go100%100%100%
   msgs.go100%100%67.94%..., 66, 79, 96, 97

app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
kruspy and others added 6 commits January 22, 2024 14:33
Co-authored-by: Puneet <[email protected]>
Co-authored-by: Puneet <[email protected]>
Co-authored-by: Puneet <[email protected]>
Co-authored-by: Puneet <[email protected]>
Co-authored-by: Puneet <[email protected]>
Co-authored-by: Puneet <[email protected]>
Copy link

Coverage after merging fix/per-chain-c-value into main

70.00%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstake/keeper
   liquidstake.go100%100%61.61%..., 647, 92, 93, 99
   genesis.go100%100%86.96%14, 23, 32
   rebalancing.go100%100%93.33%..., 45, 46, 81, 82
   grpc_query.go100%100%100%
   keeper.go100%100%77.50%..., 92, 95, 96, 97
x/liquidstake/types
   params.go100%100%83.19%..., 195, 196, 87, 88
   keys.go100%100%100%
   liquidstake.go100%100%93.57%..., 63, 64, 73, 81
   genesis.go100%100%100%
   codec.go100%100%100%
   msgs.go100%100%40.58%..., 96, 97, 98, 99
   rebalancing.go100%100%84%22, 23, 40, 41
x/liquidstakeibc
   module.go100%100%56.10%..., 96, 97, 98, 99
   genesis.go100%100%100%
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
x/liquidstakeibc/keeper
   deposit.go100%100%99.02%87, 88
   hooks.go100%100%42.18%..., 909, 910, 944, 945
   host_chain.go100%100%99.64%129
   ibc.go100%100%23.66%..., 93, 94, 95, 96
   icq.go100%100%75.90%..., 233, 43, 44, 45
   redelegation_txs.go100%100%100%
   grpc_querier.go100%100%95.17%..., 310, 311, 319, 320
   abci.go100%100%74.63%..., 83, 84, 85, 86
   rebalance.go100%100%91.21%..., 115, 116, 77, 80
   redelegation.go100%100%100%
   user_unbonding.go100%100%100%
   icq_queries.go100%100%80%..., 144, 145, 146, 147
   keeper.go100%100%96.80%..., 366, 374, 93, 94
   msg_server.go100%100%61.08%..., 963, 964, 967, 968
   unbonding.go100%100%100%
   delegation_strategy.go100%100%100%
   migrations.go100%100%33.33%..., 23, 26, 27, 28
   invariants.go100%100%100%
   ica.go100%100%65%..., 70, 71, 72, 73
   ica_handlers.go100%100%29.18%..., 96, 97, 98, 99
   lsm_deposit.go100%100%100%
   validator_unbonding.go100%100%100%
x/liquidstakeibc/types
   params.go100%100%100%
   genesis.go100%100%100%
   liquidstakeibc.go100%100%97.83%17, 18, 19
   msgs.go100%100%86.32%..., 380, 381, 482, 483
   codec.go100%100%100%
   host_chain.go100%100%100%
   keys.go100%100%0%..., 122, 96, 97, 98
   hooks.go100%100%0%..., 29, 30, 31, 34
x/ratesync
   module_simulation.go100%100%0%..., 79, 80, 81, 82
   module.go100%100%64.06%..., 80, 83, 84, 85
   genesis.go100%100%100%
   module_ibc.go100%100%9.09%..., 96, 97, 98, 99
x/ratesync/keeper
   msg_server.go100%100%74.91%..., 63, 64, 65, 66
   abci.go100%100%95.65%36
   params.go100%100%84.62%14, 15
   query.go100%100%85.71%..., 40, 41, 47, 48
   ica_tx.go100%100%71.53%..., 83, 84, 85, 86
   ibc.go100%100%67.09%..., 55, 67, 68, 69
   keeper.go100%100%78.38%..., 80, 81, 88, 89
   hooks.go100%100%87.76%..., 27, 28, 68, 69
   chain.go100%100%100%
x/ratesync/types
   codec.go100%100%0%..., 26, 27, 28, 29
   genesis.go100%100%100%
   msgs.go100%100%67.94%..., 66, 79, 96, 97
   params.go100%100%75%31, 32, 33, 34
   keys.go100%100%100%
   types.go100%100%96.36%..., 128, 129, 28, 29

Copy link

Coverage after merging fix/per-chain-c-value into main

70.38%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstake/keeper
   keeper.go100%100%77.50%..., 92, 95, 96, 97
   rebalancing.go100%100%93.33%..., 45, 46, 81, 82
   grpc_query.go100%100%100%
   liquidstake.go100%100%61.61%..., 647, 92, 93, 99
   genesis.go100%100%86.96%14, 23, 32
x/liquidstake/types
   msgs.go100%100%40.58%..., 96, 97, 98, 99
   rebalancing.go100%100%84%22, 23, 40, 41
   genesis.go100%100%100%
   params.go100%100%83.19%..., 195, 196, 87, 88
   liquidstake.go100%100%93.57%..., 63, 64, 73, 81
   keys.go100%100%100%
   codec.go100%100%100%
x/liquidstakeibc
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
   module.go100%100%56.10%..., 96, 97, 98, 99
   genesis.go100%100%100%
x/liquidstakeibc/keeper
   icq.go100%100%75.90%..., 233, 43, 44, 45
   abci.go100%100%74.63%..., 83, 84, 85, 86
   hooks.go100%100%42.18%..., 909, 910, 944, 945
   ica.go100%100%65%..., 70, 71, 72, 73
   redelegation.go100%100%100%
   delegation_strategy.go100%100%100%
   rebalance.go100%100%91.21%..., 115, 116, 77, 80
   invariants.go100%100%100%
   redelegation_txs.go100%100%100%
   validator_unbonding.go100%100%100%
   ica_handlers.go100%100%29.18%..., 96, 97, 98, 99
   icq_queries.go100%100%80%..., 144, 145, 146, 147
   lsm_deposit.go100%100%100%
   grpc_querier.go100%100%95.17%..., 310, 311, 319, 320
   host_chain.go100%100%99.64%129
   keeper.go100%100%96.80%..., 366, 374, 93, 94
   user_unbonding.go100%100%100%
   ibc.go100%100%23.66%..., 93, 94, 95, 96
   msg_server.go100%100%60.86%..., 98, 981, 982, 99
   unbonding.go100%100%100%
   deposit.go100%100%99.02%87, 88
   migrations.go100%100%33.33%..., 23, 26, 27, 28
x/liquidstakeibc/types
   hooks.go100%100%0%..., 29, 30, 31, 34
   liquidstakeibc.go100%100%100%
   msgs.go100%100%89.01%..., 380, 381, 482, 483
   params.go100%100%100%
   host_chain.go100%100%100%
   codec.go100%100%100%
   genesis.go100%100%100%
   keys.go100%100%0%..., 122, 96, 97, 98
x/ratesync
   module_ibc.go100%100%9.09%..., 96, 97, 98, 99
   module_simulation.go100%100%0%..., 79, 80, 81, 82
   module.go100%100%64.06%..., 80, 83, 84, 85
   genesis.go100%100%100%
x/ratesync/keeper
   msg_server.go100%100%74.91%..., 63, 64, 65, 66
   hooks.go100%100%87.76%..., 27, 28, 68, 69
   ica_tx.go100%100%71.53%..., 83, 84, 85, 86
   abci.go100%100%95.65%36
   query.go100%100%85.71%..., 40, 41, 47, 48
   chain.go100%100%100%
   params.go100%100%84.62%14, 15
   ibc.go100%100%67.09%..., 55, 67, 68, 69
   keeper.go100%100%78.38%..., 80, 81, 88, 89
x/ratesync/types
   keys.go100%100%100%
   types.go100%100%96.36%..., 128, 129, 28, 29
   codec.go100%100%0%..., 26, 27, 28, 29
   msgs.go100%100%67.94%..., 66, 79, 96, 97
   genesis.go100%100%100%
   params.go100%100%75%31, 32, 33, 34

Copy link

Coverage after merging fix/per-chain-c-value into main

70.40%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstake/keeper
   genesis.go100%100%86.96%14, 23, 32
   liquidstake.go100%100%61.61%..., 647, 92, 93, 99
   grpc_query.go100%100%100%
   keeper.go100%100%77.50%..., 92, 95, 96, 97
   rebalancing.go100%100%93.33%..., 45, 46, 81, 82
x/liquidstake/types
   keys.go100%100%100%
   params.go100%100%83.19%..., 195, 196, 87, 88
   codec.go100%100%100%
   genesis.go100%100%100%
   liquidstake.go100%100%93.57%..., 63, 64, 73, 81
   rebalancing.go100%100%84%22, 23, 40, 41
   msgs.go100%100%40.58%..., 96, 97, 98, 99
x/liquidstakeibc
   module.go100%100%56.10%..., 96, 97, 98, 99
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
   genesis.go100%100%100%
x/liquidstakeibc/keeper
   host_chain.go100%100%99.64%129
   delegation_strategy.go100%100%100%
   icq.go100%100%75.90%..., 233, 43, 44, 45
   abci.go100%100%74.63%..., 83, 84, 85, 86
   ibc.go100%100%23.66%..., 93, 94, 95, 96
   redelegation.go100%100%100%
   lsm_deposit.go100%100%100%
   redelegation_txs.go100%100%100%
   ica_handlers.go100%100%29.18%..., 96, 97, 98, 99
   icq_queries.go100%100%80%..., 144, 145, 146, 147
   hooks.go100%100%42.18%..., 909, 910, 944, 945
   keeper.go100%100%96.80%..., 366, 374, 93, 94
   validator_unbonding.go100%100%100%
   rebalance.go100%100%91.21%..., 115, 116, 77, 80
   grpc_querier.go100%100%95.17%..., 310, 311, 319, 320
   ica.go100%100%65%..., 70, 71, 72, 73
   invariants.go100%100%100%
   msg_server.go100%100%61.06%..., 982, 983, 986, 987
   deposit.go100%100%99.02%87, 88
   unbonding.go100%100%100%
   migrations.go100%100%33.33%..., 23, 26, 27, 28
   user_unbonding.go100%100%100%
x/liquidstakeibc/types
   hooks.go100%100%0%..., 29, 30, 31, 34
   host_chain.go100%100%100%
   liquidstakeibc.go100%100%100%
   keys.go100%100%0%..., 122, 96, 97, 98
   codec.go100%100%100%
   genesis.go100%100%100%
   msgs.go100%100%89.01%..., 380, 381, 482, 483
   params.go100%100%100%
x/ratesync
   module_simulation.go100%100%0%..., 79, 80, 81, 82
   module_ibc.go100%100%9.09%..., 96, 97, 98, 99
   genesis.go100%100%100%
   module.go100%100%64.06%..., 80, 83, 84, 85
x/ratesync/keeper
   query.go100%100%85.71%..., 40, 41, 47, 48
   abci.go100%100%95.65%36
   hooks.go100%100%87.76%..., 27, 28, 68, 69
   msg_server.go100%100%74.91%..., 63, 64, 65, 66
   ica_tx.go100%100%71.53%..., 83, 84, 85, 86
   ibc.go100%100%67.09%..., 55, 67, 68, 69
   chain.go100%100%100%
   params.go100%100%84.62%14, 15
   keeper.go100%100%78.38%..., 80, 81, 88, 89
x/ratesync/types
   params.go100%100%75%31, 32, 33, 34
   msgs.go100%100%67.94%..., 66, 79, 96, 97
   genesis.go100%100%100%
   types.go100%100%96.36%..., 128, 129, 28, 29
   keys.go100%100%100%
   codec.go100%100%0%..., 26, 27, 28, 29

@kruspy kruspy merged commit 633526e into main Jan 22, 2024
8 of 11 checks passed
@kruspy kruspy deleted the fix/per-chain-c-value branch January 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants