Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: genesis validate, deposits validate. #730

Merged
merged 3 commits into from
Jan 19, 2024
Merged

fix: genesis validate, deposits validate. #730

merged 3 commits into from
Jan 19, 2024

Conversation

puneet2019
Copy link
Member

allow DEPOSIT_SENT state to validate deposit

@puneet2019 puneet2019 requested a review from a team as a code owner January 19, 2024 12:25
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Coverage after merging puneet/oak-10 into main

70.26%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstake/keeper
   keeper.go100%100%77.50%..., 92, 95, 96, 97
   grpc_query.go100%100%100%
   rebalancing.go100%100%93.33%..., 45, 46, 81, 82
   liquidstake.go100%100%61.61%..., 647, 92, 93, 99
   genesis.go100%100%86.96%14, 23, 32
x/liquidstake/types
   params.go100%100%83.19%..., 195, 196, 87, 88
   liquidstake.go100%100%93.57%..., 63, 64, 73, 81
   keys.go100%100%100%
   rebalancing.go100%100%84%22, 23, 40, 41
   codec.go100%100%100%
   msgs.go100%100%40.58%..., 96, 97, 98, 99
   genesis.go100%100%100%
x/liquidstakeibc
   module.go100%100%56.10%..., 96, 97, 98, 99
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
   genesis.go100%100%100%
x/liquidstakeibc/keeper
   validator_unbonding.go100%100%100%
   icq_queries.go100%100%80%..., 144, 145, 146, 147
   abci.go100%100%74.63%..., 83, 84, 85, 86
   ica_handlers.go100%100%29.18%..., 96, 97, 98, 99
   redelegation_txs.go100%100%100%
   hooks.go100%100%42.18%..., 909, 910, 944, 945
   icq.go100%100%75.90%..., 233, 43, 44, 45
   deposit.go100%100%99.02%87, 88
   ica.go100%100%65%..., 70, 71, 72, 73
   unbonding.go100%100%100%
   grpc_querier.go100%100%95.17%..., 310, 311, 319, 320
   delegation_strategy.go100%100%100%
   rebalance.go100%100%91.21%..., 115, 116, 77, 80
   ibc.go100%100%23.64%..., 93, 94, 95, 96
   redelegation.go100%100%100%
   user_unbonding.go100%100%100%
   host_chain.go100%100%99.64%129
   migrations.go100%100%33.33%..., 23, 26, 27, 28
   lsm_deposit.go100%100%100%
   msg_server.go100%100%62.03%..., 950, 953, 954, 96
   keeper.go100%100%96.80%..., 366, 374, 93, 94
   invariants.go100%100%100%
x/liquidstakeibc/types
   host_chain.go100%100%100%
   liquidstakeibc.go100%100%97.83%17, 18, 19
   params.go100%100%100%
   msgs.go100%100%89.53%..., 362, 363, 464, 465
   keys.go100%100%0%..., 94, 96, 97, 98
   genesis.go100%100%100%
   hooks.go100%100%0%..., 29, 30, 31, 34
   codec.go100%100%100%
x/ratesync
   module.go100%100%64.06%..., 80, 83, 84, 85
   genesis.go100%100%100%
   module_ibc.go100%100%9.09%..., 96, 97, 98, 99
   module_simulation.go100%100%0%..., 79, 80, 81, 82
x/ratesync/keeper
   query.go100%100%85.71%..., 40, 41, 47, 48
   hooks.go100%100%87.76%..., 27, 28, 68, 69
   chain.go100%100%100%
   keeper.go100%100%78.38%..., 80, 81, 88, 89
   ibc.go100%100%67.09%..., 55, 67, 68, 69
   msg_server.go100%100%74.91%..., 63, 64, 65, 66
   abci.go100%100%95.65%36
   ica_tx.go100%100%71.53%..., 83, 84, 85, 86
   params.go100%100%84.62%14, 15
x/ratesync/types
   codec.go100%100%0%..., 26, 27, 28, 29
   genesis.go100%100%100%
   msgs.go100%100%67.94%..., 66, 79, 96, 97
   params.go100%100%75%31, 32, 33, 34
   keys.go100%100%100%
   types.go100%100%96.36%..., 128, 129, 28, 29

@github-actions GitHub Actions
Copy link

Coverage after merging puneet/oak-10 into main

70.21%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstake/keeper
   liquidstake.go100%100%61.61%..., 647, 92, 93, 99
   rebalancing.go100%100%93.33%..., 45, 46, 81, 82
   grpc_query.go100%100%100%
   genesis.go100%100%86.96%14, 23, 32
   keeper.go100%100%77.50%..., 92, 95, 96, 97
x/liquidstake/types
   genesis.go100%100%100%
   keys.go100%100%100%
   msgs.go100%100%40.58%..., 96, 97, 98, 99
   codec.go100%100%100%
   params.go100%100%83.19%..., 195, 196, 87, 88
   liquidstake.go100%100%93.57%..., 63, 64, 73, 81
   rebalancing.go100%100%84%22, 23, 40, 41
x/liquidstakeibc
   genesis.go100%100%100%
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
   module.go100%100%56.10%..., 96, 97, 98, 99
x/liquidstakeibc/keeper
   abci.go100%100%74.63%..., 83, 84, 85, 86
   redelegation_txs.go100%100%100%
   deposit.go100%100%99.02%87, 88
   ica.go100%100%65%..., 70, 71, 72, 73
   ica_handlers.go100%100%29.18%..., 96, 97, 98, 99
   delegation_strategy.go100%100%100%
   user_unbonding.go100%100%100%
   msg_server.go100%100%62.03%..., 950, 953, 954, 96
   hooks.go100%100%42.18%..., 909, 910, 944, 945
   icq_queries.go100%100%80%..., 144, 145, 146, 147
   invariants.go100%100%100%
   lsm_deposit.go100%100%100%
   unbonding.go100%100%100%
   grpc_querier.go100%100%95.17%..., 310, 311, 319, 320
   keeper.go100%100%96.80%..., 366, 374, 93, 94
   migrations.go100%100%33.33%..., 23, 26, 27, 28
   rebalance.go100%100%91.21%..., 115, 116, 77, 80
   redelegation.go100%100%100%
   ibc.go100%100%23.66%..., 93, 94, 95, 96
   host_chain.go100%100%99.64%129
   validator_unbonding.go100%100%100%
   icq.go100%100%75.90%..., 233, 43, 44, 45
x/liquidstakeibc/types
   msgs.go100%100%89.53%..., 362, 363, 464, 465
   hooks.go100%100%0%..., 29, 30, 31, 34
   host_chain.go100%100%100%
   liquidstakeibc.go100%100%97.83%17, 18, 19
   genesis.go100%100%100%
   codec.go100%100%100%
   params.go100%100%100%
   keys.go100%100%0%..., 94, 96, 97, 98
x/ratesync
   module_ibc.go100%100%9.09%..., 96, 97, 98, 99
   module.go100%100%64.06%..., 80, 83, 84, 85
   module_simulation.go100%100%0%..., 79, 80, 81, 82
   genesis.go100%100%100%
x/ratesync/keeper
   ibc.go100%100%67.09%..., 55, 67, 68, 69
   ica_tx.go100%100%71.53%..., 83, 84, 85, 86
   abci.go100%100%95.65%36
   hooks.go100%100%87.76%..., 27, 28, 68, 69
   query.go100%100%85.71%..., 40, 41, 47, 48
   msg_server.go100%100%74.91%..., 63, 64, 65, 66
   keeper.go100%100%78.38%..., 80, 81, 88, 89
   chain.go100%100%100%
   params.go100%100%84.62%14, 15
x/ratesync/types
   types.go100%100%96.36%..., 128, 129, 28, 29
   params.go100%100%75%31, 32, 33, 34
   keys.go100%100%100%
   genesis.go100%100%100%
   codec.go100%100%0%..., 26, 27, 28, 29
   msgs.go100%100%67.94%..., 66, 79, 96, 97

@kruspy kruspy merged commit 8ef9742 into main Jan 19, 2024
10 checks passed
@kruspy kruspy deleted the puneet/oak-10 branch January 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruspy kruspy kruspy approved these changes

Assignees
No one assigned
Labels
C:x/liquidstakeibc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puneet2019 @kruspy