Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scrappy code to relay packets in case of timeout #555

Closed
wants to merge 2 commits into from

Conversation

puneet2019
Copy link
Member

@puneet2019 puneet2019 commented Jul 3, 2023

Do not merge,
uses lens client to clear some stuck ibc timeout packets.. given the packet sequence and channel/ ports

hermes takes care of this from v1.6.0

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Coverage after merging puneet/relaypackets into main

38.30%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstakeibc
   module_ibc.go100%100%9.80%..., 86, 87, 88, 89
   genesis.go100%100%58.62%..., 29, 30, 44, 45
   module.go100%100%52.78%..., 72, 73, 74, 99
x/liquidstakeibc/keeper
   keeper.go100%100%23.42%..., 337, 338, 84, 85
   validator_unbonding.go100%100%100%
   icq.go100%100%16.39%..., 96, 97, 98, 99
   grpc_querier.go100%100%65.63%..., 210, 211, 212, 214
   unbonding.go100%100%85.94%..., 66, 67, 68, 69
   abci.go100%100%2.14%..., 96, 97, 98, 99
   delegation_strategy.go100%100%98.61%114
   deposit.go100%100%84%..., 270, 271, 272, 275
   ibc.go100%100%0%..., 95, 96, 97, 98
   user_unbonding.go100%100%84.78%..., 68, 69, 70, 71
   hooks.go100%100%11.06%..., 671, 71, 72, 73
   msg_server.go100%100%0.54%..., 96, 97, 98, 99
   ica.go100%100%0%..., 82, 83, 84, 85
   ica_handlers.go100%100%0%..., 94, 95, 98, 99
   icq_queries.go100%100%22.22%..., 91, 92, 93, 94
   host_chain.go100%100%83.89%..., 82, 83, 84, 85
x/liquidstakeibc/types
   liquidstakeibc.go100%100%0%..., 96, 97, 98, 99
   params.go100%100%68.12%..., 94, 95, 98, 99
   codec.go100%100%52%..., 30, 31, 32, 33
   keys.go100%100%0%..., 61, 63, 64, 65
   msgs.go100%100%0%..., 94, 95, 98, 99
   genesis.go100%100%20%..., 96, 97, 98, 99
   host_chain.go100%100%0%..., 30, 32, 8, 9
x/lscosmos
   module_simulation.go100%100%5.56%..., 46, 47, 48, 49
   module_ibc.go100%100%0%..., 85, 93, 94, 95
   genesis.go100%100%77.42%..., 29, 30, 32, 33
   module.go100%100%63.38%..., 87, 90, 91, 92
x/lscosmos/client/utils
   utils.go100%100%41.33%..., 94, 95, 96, 98
x/lscosmos/keeper
   delegation_state.go100%100%40.28%..., 89, 90, 91, 94
   unbonding_epoch_c_value.go100%100%0%..., 55, 56, 57, 9
   hooks.go100%100%1.33%..., 91, 92, 93, 96
   allowlisted_validators.go100%100%100%
   keeper.go100%100%50%..., 96, 97, 98, 99
   delegation_strategy.go100%100%57.78%..., 89, 91, 98, 99
   c_value.go100%100%93.33%31, 32, 41, 42
   governance_proposal.go100%100%0%..., 19, 20, 21, 9
   delegator_unbonding_epoch_entry.go100%100%72.88%..., 72, 73, 74, 76
   handshake.go100%100%0%..., 96, 97, 98, 99
   params.go100%100%100%
   icq_callbacks.go100%100%0%..., 67, 70, 71, 72
   msg_server.go100%100%11.11%..., 54, 57, 58, 59
   ica_txs.go100%100%0%..., 89, 90, 91, 92
   migrate_module.go100%100%0%..., 95, 96, 97, 98
   transient_store.go100%100%68.75%..., 74, 75, 76, 78
   module_state.go100%100%100%
   host_accounts.go100%100%33.33%..., 20, 21, 22, 23
   grpc_query.go100%100%0%..., 93, 96, 97, 98
   host_chain_params.go100%100%100%
   invariants.go100%100%42.11%..., 30, 31, 32, 33
   host_chain_reward_address.go100%100%100%
   genesis.go100%100%0%..., 21, 22, 8, 9
   abci.go100%100%1.61%..., 88, 89, 90, 92
   grpc_query_params.go100%100%0%10, 11, 12
x/lscosmos/types
   codec.go100%100%46.15%..., 46, 47, 48, 49
   governance_proposal.go100%100%82.98%..., 59, 60, 61, 64
   lscosmos.go100%100%16.99%..., 94, 95, 96, 99
   genesis.go100%100%87.10%29, 30, 31, 32
   delegation_strategy.go100%100%80.72%..., 125, 126, 127, 66
   msgs.go100%100%11.66%..., 96, 97, 98, 99
   params.go100%100%47.37%..., 36, 37, 38, 39
   keys.go100%100%0%..., 133, 137, 138, 139
x/lspersistence/keeper
   rebalancing.go100%100%92.96%..., 45, 46, 75, 76
   liquidstaking.go100%100%88.12%..., 54, 55, 84, 85
   test_common.go100%100%0%..., 30, 31, 32, 33
   keeper.go100%100%82.86%..., 62, 76, 77, 83
   genesis.go100%100%86.96%14, 22, 31
   grpc_query.go100%100%100%
   invariants.go100%100%74.39%..., 56, 58, 59, 60
x/lspersistence/simulation
   operations.go100%100%75.65%..., 93, 94, 97, 98
   decoder.go100%100%100%
   proposals.go100%100%96.30%129, 130, 131
x/lspersistence/types
   params.go100%100%75%..., 86, 87, 98, 99
   msgs.go100%100%89.89%..., 57, 65, 93, 94
   keys.go100%100%100%
   genesis.go100%100%100%
   rebalancing.go100%100%84%22, 23, 38, 39
   liquidstaking.go100%100%93.57%..., 62, 63, 71, 78
   codec.go100%100%100%

@kruspy
Copy link
Collaborator

kruspy commented Sep 13, 2023

Do we still need this ?

@puneet2019 puneet2019 changed the title scrappy code to relay packets in case of timeout feat: scrappy code to relay packets in case of timeout Sep 19, 2023
@puneet2019 puneet2019 closed this Sep 19, 2023
@puneet2019
Copy link
Member Author

Do we still need this ?

closing, not needed unless relayers start bugging out

@github-actions
Copy link

Coverage after merging puneet/relaypackets into main

72.12%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
x/liquidstakeibc
   module_ibc.go100%100%8.93%..., 88, 89, 90, 91
   module.go100%100%54.32%..., 72, 73, 74, 99
   genesis.go100%100%100%
x/liquidstakeibc/keeper
   delegation_strategy.go100%100%100%
   migrations.go100%100%50%20, 21, 22
   user_unbonding.go100%100%100%
   deposit.go100%100%100%
   invariants.go100%100%100%
   ibc.go100%100%37.60%..., 91, 92, 93, 94
   grpc_querier.go100%100%100%
   keeper.go100%100%99.09%90, 91
   abci.go100%100%42.74%..., 79, 80, 81, 82
   ica_handlers.go100%100%32.42%..., 94, 95, 96, 97
   msg_server.go100%100%60.08%..., 94, 95, 96, 97
   ica.go100%100%65.57%..., 71, 72, 73, 74
   unbonding.go100%100%100%
   validator_unbonding.go100%100%100%
   hooks.go100%100%42.23%..., 732, 733, 734, 74
   host_chain.go100%100%99.56%106
   icq_queries.go100%100%100%
   lsm_deposit.go100%100%100%
   icq.go100%100%94.26%..., 173, 39, 40, 41
x/liquidstakeibc/types
   keys.go100%100%0%..., 94, 96, 97, 98
   liquidstakeibc.go100%100%100%
   codec.go100%100%100%
   host_chain.go100%100%100%
   msgs.go100%100%95.06%..., 335, 336, 439, 440
   params.go100%100%100%
   genesis.go100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants