test(mu): add tests for cron monitor functions #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrdn91
force-pushed
the
jrdn91/test-mu-cron-process
branch
from
bb0dd6d to
e2d37ec
Compare
TillaTheHun0
force-pushed
the
jrdn91/test-mu-cron-process
branch
2 times, most recently
from
3c69105 to
f4dee4a
Compare
TillaTheHun0
force-pushed
the
jrdn91/test-mu-cron-process
branch
from
f4dee4a to
3dccb33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a refactor to the init monitor HOF so that it can be tested and adds some initial tests for the init function and the "kill" function.
TODO: tests still need to be added for
startMonitoredProcessWithand it will probably need refactored to add dependency injection to make it testable.The "kill" function probably needs another test or may also need refactored for dependency injection to properly test it.