Destroy envhp with last dbh #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the order of object destruction during "global destruction" is undefined. DBI traces show that the global environment is freed in the driver destruction process before all database connections are closed and their resources freed. This causes the segfault in #65. This change moved freeing of the global environment handle from the destruction of the driver handle (dbd_dr_destroy()) to the destruction of the database handle (dbd_db_destroy()). This implementation closes the global environment handle during the DBI shutdown process if the last database handle uses the global environment handle. If the last database handles uses a session environment handle, the global environment handle will not be destroyed.
|
See also #89 |
This was referenced Jun 24, 2019
|
I created this travis-perl/helpers#74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try this