-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial swiftlint file and fixes #781
Initial swiftlint file and fixes #781
Conversation
a627097
to
56a4d1b
Compare
Would love to get general feedback @ileitch if you think this it too aggressive an approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding this!
I think we can just drop the cyclomatic complexity and body/file length rules and merge as-is. I will go through later and tweak/fix the rules a little.
That's quite ok. Thanks for picking it up!
Shall I make the changes as per your comments, and then you can make any additional ones on top, just so we're not stepping on each others toes? I should be able to get to it tonight or tomorrow at latest ... |
I think let's just remove the cyclomatic complexity and body/file length rules in this PR, then any other tweaks can be made in follow-up PRs. |
Cool - should be good to go! |
So this branch has a .swiftlint.yml, and a lot of fixes - I went pretty aggressive here in enabling as much as possible, and also fixing the issues.
There are no really material code changes - many of them were, for example, the "imports weren't sorted", but if you'd prefer a less aggressive approach, let me know.
What there isn't here is any CI or Xcode integration.