Include Line and Column in Location for JSON and CSV Outputs - Issue 680 #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Hi @ileitch 👋 Any idea when there will be a new release with this PR included? I couldn't find a way to use this PR's fix without building the project locally, is there a way? Installing via cocoapods pointing at master won't contain an executable binary, for instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
locationDescriptionfunction to the OutputFormatter class. JsonFormatter and CsvFormatter both use this function to build the location included in their outputs, appending line and column to the file path created byoutputPath.I compared the results of all supported output formats against version 2.16.0. Only the csv and json output formats had been affected by the regression from 2.16.0 to 2.17.0.