Prototype diff formatting for discussion #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a unfinished prototype for discussing an implementation of a feature.
It would be good to be able to see not only that actual and expected results are different,
but also one would like to see in which way they differ.
I couldnt find a way to extend leo for diffing in plugin-kind of way. So I started prototyping.
This commit prototypes a possible implementation with the following properties
each matcher supporting diffs (see SameMatcher) gets a $differ method to be called by the formatter
This indicates
So this bears the questions:
** should diff calculation happen when matching or when formatting