Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(8.4) PS-9453: percona_telemetry causes a long wait on COND_thd_list due to the absence of the root user #5471

Conversation

kamil-holubicki
Copy link
Contributor

@kamil-holubicki kamil-holubicki commented Nov 1, 2024

https://perconadev.atlassian.net/browse/PS-9453

Cherry pick from 8.0.

Post push fix-2.

Revoked commits 9078f2d, 60a65b3.

Percona Telemetry Component uses a dedicated user percona.telemetry.

Conflicts:
mysql-test/suite/auth_sec/r/atomic_alter_user.result # mysql-test/t/mysqlpump_extended.test

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@@ -1,2 +1,2 @@
--sorted_result
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
expected unqualified-id

@@ -30,7 +30,7 @@ let NEW_CMD = $MYSQLD --no-defaults --initialize-insecure --datadir=$MYSQLD_DATA
--source include/restart_mysqld.inc

SELECT current_user;
SELECT user, plugin FROM mysql.user;
SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
unknown type name SELECT

@@ -30,7 +30,7 @@
--source include/restart_mysqld.inc

SELECT current_user;
SELECT user, plugin FROM mysql.user;
SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
expected ; after top level declarator

Suggested change
SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry';
SELECT user, plugin; FROM mysql.user WHERE user != 'percona.telemetry';

@@ -30,7 +30,7 @@
--source include/restart_mysqld.inc

SELECT current_user;
SELECT user, plugin FROM mysql.user;
SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry';

--echo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
expected unqualified-id

… the absence of the root user

https://perconadev.atlassian.net/browse/PS-9453

Cherry pick from 8.0.

Post push fix-2.

Revoked commits 9078f2d, 60a65b3.

Percona Telemetry Component uses a dedicated user percona.telemetry.

# Conflicts:
#	mysql-test/suite/auth_sec/r/atomic_alter_user.result
#	mysql-test/t/mysqlpump_extended.test
Copy link
Contributor

@dlenev dlenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kamil-holubicki kamil-holubicki merged commit 4d63091 into percona:release-8.4.3-3 Nov 6, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants