-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(8.4) PS-9453: percona_telemetry causes a long wait on COND_thd_list due to the absence of the root user #5471
(8.4) PS-9453: percona_telemetry causes a long wait on COND_thd_list due to the absence of the root user #5471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
@@ -1,2 +1,2 @@ | |||
--sorted_result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected unqualified-id
@@ -30,7 +30,7 @@ let NEW_CMD = $MYSQLD --no-defaults --initialize-insecure --datadir=$MYSQLD_DATA | |||
--source include/restart_mysqld.inc | |||
|
|||
SELECT current_user; | |||
SELECT user, plugin FROM mysql.user; | |||
SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unknown type name SELECT
@@ -30,7 +30,7 @@ | |||
--source include/restart_mysqld.inc | |||
|
|||
SELECT current_user; | |||
SELECT user, plugin FROM mysql.user; | |||
SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected ;
after top level declarator
SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry'; | |
SELECT user, plugin; FROM mysql.user WHERE user != 'percona.telemetry'; |
@@ -30,7 +30,7 @@ | |||
--source include/restart_mysqld.inc | |||
|
|||
SELECT current_user; | |||
SELECT user, plugin FROM mysql.user; | |||
SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry'; | |||
|
|||
--echo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected unqualified-id
… the absence of the root user https://perconadev.atlassian.net/browse/PS-9453 Cherry pick from 8.0. Post push fix-2. Revoked commits 9078f2d, 60a65b3. Percona Telemetry Component uses a dedicated user percona.telemetry. # Conflicts: # mysql-test/suite/auth_sec/r/atomic_alter_user.result # mysql-test/t/mysqlpump_extended.test
c1710d5
to
0a5e0ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
4d63091
into
percona:release-8.4.3-3
https://perconadev.atlassian.net/browse/PS-9453
Cherry pick from 8.0.
Post push fix-2.
Revoked commits 9078f2d, 60a65b3.
Percona Telemetry Component uses a dedicated user percona.telemetry.
Conflicts:
mysql-test/suite/auth_sec/r/atomic_alter_user.result # mysql-test/t/mysqlpump_extended.test