PS-9453: percona_telemetry causes a long wait on COND_thd_list due to the absence of the root user #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-holubicki
requested review from
percona-ysorokin,
dlenev and
lukin-oleksiy
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,2 +1,2 @@ | |||
| --sorted_result | |||
There was a problem hiding this comment.
expected unqualified-id
| @@ -30,7 +30,7 @@ let NEW_CMD = $MYSQLD --no-defaults --initialize-insecure --datadir=$MYSQLD_DATA | |||
| --source include/restart_mysqld.inc | |||
|
|
|||
| SELECT current_user; | |||
| SELECT user, plugin FROM mysql.user; | |||
| SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry'; | |||
There was a problem hiding this comment.
unknown type name SELECT
| @@ -30,7 +30,7 @@ | |||
| --source include/restart_mysqld.inc | |||
|
|
|||
| SELECT current_user; | |||
| SELECT user, plugin FROM mysql.user; | |||
| SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry'; | |||
There was a problem hiding this comment.
expected ; after top level declarator
Suggested change
| SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry'; | |
| SELECT user, plugin; FROM mysql.user WHERE user != 'percona.telemetry'; |
| @@ -30,7 +30,7 @@ | |||
| --source include/restart_mysqld.inc | |||
|
|
|||
| SELECT current_user; | |||
| SELECT user, plugin FROM mysql.user; | |||
| SELECT user, plugin FROM mysql.user WHERE user != 'percona.telemetry'; | |||
|
|
|||
| --echo | |||
There was a problem hiding this comment.
expected unqualified-id
dlenev
requested changes
Nov 4, 2024
… the absence of the root user https://perconadev.atlassian.net/browse/PS-9453 Post push fix-2. Revoked commits 9078f2d, 60a65b3. Percona Telemetry Component uses a dedicated user percona.telemetry.
kamil-holubicki
force-pushed
the
PS-9453-post-push-fix-2-8.0
branch
from
2b399ea
to
da94357
Compare
kamil-holubicki
merged commit 5aca63e
into
percona:release-8.0.40-31
22 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9453
Post push fix-2.
Revoked commits 9078f2d, 60a65b3.
Percona Telemetry Component uses a dedicated user percona.telemetry.