This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
EVEREST-392 accept PMM instance with invalidcert #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Reviewers I'm aware this isn't safe in general, hence the draft PR but I need you to evaluate whether we need to have this right now.
Accept PMM instance with invalid cert
Problem:
EVEREST-392
We can't connect to PMM instances with invalid certs
Cause:
go's http module forces TLS cert validation (as it should)
Solution:
Don't validate TLS certificate in the initial connection to PMM.
CHECKLIST
Jira
Tests
[ ] Is an Integration test/test case added for the new feature/change?No 😢 we don't have the necessary infrastructure in place to do this hours before the release[ ] Are unit tests added where appropriate?Can't unit test this