Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.22.0 #314

Merged
merged 55 commits into from
Jun 7, 2019
Merged

0.22.0 #314

merged 55 commits into from
Jun 7, 2019

Conversation

nsheff
Copy link
Contributor

@nsheff nsheff commented May 29, 2019

In support of looper 0.12.2

We need to get a functioning release version of looper.

Milestone issues: https://github.com/pepkit/peppy/milestone/12

@nsheff
Copy link
Contributor Author

nsheff commented Jun 4, 2019

is this ready to be merged/released?

@nsheff nsheff requested a review from vreuter June 4, 2019 02:23
@nsheff
Copy link
Contributor Author

nsheff commented Jun 4, 2019

I'd like to merge this today. Does this incorporate the index flexibility requested in snakemake-workflows/dna-seq-gatk-variant-calling#8 (comment) ?

@nsheff nsheff added this to the 0.22 milestone Jun 4, 2019
@vreuter
Copy link
Member

vreuter commented Jun 4, 2019

I'd like to merge this today. Does this incorporate the index flexibility requested in snakemake-workflows/dna-seq-gatk-variant-calling#8 (comment) ?

It will include the indexing. I have no plans to remove SnakeProject because I so fundamentally disagree with the preference against subclassing that we can discuss that separately. It was evident that removing that class was a motivation for some of the other suggestions, so it should've been made up front, rather than backdooring the design preference.

@nsheff
Copy link
Contributor Author

nsheff commented Jun 4, 2019

agreed, leave it for now, I think it's useful.

@nsheff
Copy link
Contributor Author

nsheff commented Jun 6, 2019

is this good to go?

@vreuter
Copy link
Member

vreuter commented Jun 6, 2019

Yeah

@vreuter vreuter merged commit 4f02a50 into master Jun 7, 2019
@vreuter vreuter deleted the dev branch June 7, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants