Release 0.3 #28
Merged
Release 0.3 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vreuter
reviewed
Apr 10, 2019
divvy/compute.py
Outdated
| warnings.warn("Divvy compute configuration '{}' section changed " | ||
| "to '{}'".format(old_compute_key, new_compute_key), | ||
| DeprecationWarning) | ||
| env_settings[new_compute_key] = env_settings[old_compute_key] |
There was a problem hiding this comment.
This way of handling the deprecation/backcompat allows the keys to map to different values.
vreuter
reviewed
Apr 19, 2019
| warnings.warn("Divvy compute configuration '{}' section changed " | ||
| "to '{}'".format(OLD_COMPUTE_KEY, NEW_COMPUTE_KEY), | ||
| DeprecationWarning) | ||
| env_settings[NEW_COMPUTE_KEY] = env_settings[OLD_COMPUTE_KEY] |
There was a problem hiding this comment.
It bothers me that this still allows subsequent mutations to have the keys get out of sync, but this is used in small enough fashion that I don't think it's a big deal. This sort of thing motivates pepkit/attmap#20.
Same as #28 (comment)
|
@nsheff I think this is set for merge now if you're ready |
|
great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
divvy writeanddivvy listcommands, fixes yaml warnings, reduces verbosity.