Non-Windows github actions checks fail

[pepijn-devries]

This is because dependencies libopenmpt and portaudio are not available.

[pepijn-devries]

I think this can be fixed by adding a json file at https://github.com/rstudio/r-system-requirements/tree/main/rules

[pepijn-devries]

submitted a pull request:

rstudio/r-system-requirements#191

[pepijn-devries]

Submitted fixed pull request:
rstudio/r-system-requirements#193

[pepijn-devries]

All checks except for MacOS are now OK. I probably have to update the configure script to contain brew installation of requirements

[pepijn-devries]

Builds and checks on all operating systems now seem to work. @jeroen Thanks for you contributions and suggestions! I would appreciate it if you could give the configure script a glance if it seems OK to you.

[pepijn-devries]

Fixed in 666ba01

[jeroen]

@pepijn-devries I think this line does not do anything right now:

openmpt/configure

Line 14 in 666ba01

PKG_CFLAGS="-LIBOPENMPT_EXT_INTERFACE_INTERACTIVE"

If you want to define a macro, you need to use flag -D{MACRO}, so it would need to be

-DLIBOPENMPT_EXT_INTERFACE_INTERACTIVE

Note it starts with -D; flags starting with -L and -l are for the linker and ignored in cflags.

However, given that it seemingly works without this macro perhaps it can just be removed?

[pepijn-devries]

Hi Jeroen,

Thanks for the check. 'LIBOPENMPT_EXT_INTERFACE_INTERACTIVE' should be a compiler flag to ensure that it includes a specific header file. But apparently I have specified this incorrectly, and I can still use this header file. So I guess I don't need it. I will remove it.

I'll work on adding R bindings to as much of the libraries features as possible. After a while I might want to have a look at building it for WASM. But I'll need to do some homework for that first. I might need some help with that in the future...

Cheers

[jeroen]

I wouldn't worry too much about wasm, that's very experimental stuff, and it would require building all of your dependency libs for wasm, which is a whole other business.

Don't forget to add to your readme that users can install binaries for win/mac from https://pepijn-devries.r-universe.dev/openmpt so they don't have to compile things ;)

[pepijn-devries]

Readme is updated with #15