Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create libopenmpt script #20

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Create libopenmpt script #20

merged 3 commits into from
Nov 4, 2024

Conversation

pepijn-devries
Copy link
Contributor

See also autobrew/bundler#2

Required for https://github.com/pepijn-devries/openmpt to work on MacOS

It might need some tweaking as I cannot test it from my fork...

@pepijn-devries
Copy link
Contributor Author

pepijn-devries/openmpt#7

Copy link
Contributor Author

@pepijn-devries pepijn-devries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult to test this setup while not merged with the main branch. I suggest to merge this into main branch. I will then update the configure script in my package to test it...

@jeroen
Copy link
Contributor

jeroen commented Nov 4, 2024

We actually first need to properly build the library that you download in this script 😅

@jeroen
Copy link
Contributor

jeroen commented Nov 4, 2024

I can't get it to work. I keep getting linking errors for __ZTIN9portaudio11PaExceptionE even though when linking with both -lportaudiocpp -lportaudio. I can merge it for you but it won't work, maybe you can try to figure it out.

@jeroen jeroen merged commit 1fc6fb6 into autobrew:master Nov 4, 2024
@pepijn-devries
Copy link
Contributor Author

pepijn-devries commented Nov 4, 2024

I had exactly the same problem on Windows. I had to link portaudio, but the compiler was very picky about the linking order, and it was a pain to figure out the right order (this is what worked on Windows eventually: https://github.com/pepijn-devries/openmpt/blob/master/src/Makevars.win).

We actually first need to properly build the library that you download in this script 😅

I think your refer to the configure script of my package here, right? The actual library is built by the autobrew script as I understand it. Is there an easier way to play with the linking order rather then sending subsequent pull requests? On Windows it was a painstaking process of trial and error.

@jeroen
Copy link
Contributor

jeroen commented Nov 4, 2024

Yes the linking order matters for static linking. I tried re-ordering the flags but this does not seem to be the problem.

If you're on macos you can test it by building the package and hardcode PKG_LIBS manually in your src/Makevars.in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants