Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash hotfix #625

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Crash hotfix #625

merged 5 commits into from
Sep 10, 2024

Conversation

baronhsieh2005
Copy link
Contributor

Added fixes to the following crashes:

  • MenuFragment NullPointerException: Moved toolbar visibility method to OnViewCreate so method won't be invoked on a null view (view is null at OnCreate())

  • GSRFragment IllegalStateException: Performs a context check at the getString operation at updateStatus() method to prevent method being called on a null context (The IllegalStateException is thrown when requireContext detects the context is null).

@meiron03
Copy link
Member

Note that for linting you can just download the linter yourself and call ktlint --format from the command line.

https://pinterest.github.io/ktlint/0.49.1/install/cli/

@baronhsieh2005
Copy link
Contributor Author

Thank you Vedha and Aaron!

@baronhsieh2005 baronhsieh2005 merged commit e46ae16 into main Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants