Baron Widget Newbie Project PR #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Baron Hsieh <[email protected]>
…e-final alarm manager test (want to test again if onUpdate is properly called)
meiron03
requested changes
Apr 19, 2024
PennMobile/src/main/java/com/pennapps/labs/pennmobile/DiningHallWidget.kt
Show resolved
Hide resolved
PennMobile/src/main/java/com/pennapps/labs/pennmobile/DiningHallWidget.kt
Outdated
Show resolved
Hide resolved
PennMobile/src/main/java/com/pennapps/labs/pennmobile/adapters/DiningHallWidgetAdapter.kt
Outdated
Show resolved
Hide resolved
PennMobile/src/main/java/com/pennapps/labs/pennmobile/api/DiningRequest.java
Show resolved
Hide resolved
|
Generally ok. Added some comments about Logs, formatting and unnecessary code. Please fix. |
meiron03
approved these changes
Apr 21, 2024
… declared as a separate function, the tab is not set to dining when widget is clicked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All appwidget update functionality checked via alarmmanager and unused import statements and additional comments are cleaned. The project should be ready to be merged after review. Thank you everyone!