Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added dining marker and interactive dining graphs #590

Merged
merged 1 commit into from
Oct 22, 2023
Merged

added dining marker and interactive dining graphs #590

merged 1 commit into from
Oct 22, 2023

Conversation

trinif
Copy link
Contributor

@trinif trinif commented Oct 22, 2023

I may need to make some UI changes depending on what the design team says later, but this is the main functionality.

@trinif trinif requested a review from rchhaya October 22, 2023 15:22
@JSnipes29 JSnipes29 self-requested a review October 22, 2023 16:31
JSnipes29
JSnipes29 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@JSnipes29 JSnipes29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JSnipes29 JSnipes29 merged commit 8f933db into main Oct 22, 2023
6 checks passed
rchhaya
rchhaya approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@rchhaya rchhaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks solid! i cant rly test the graph bc I don't have dining plan but julius can review that. lgtm

@meiron03 meiron03 deleted the dining_marker branch February 13, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchhaya rchhaya rchhaya approved these changes

@JSnipes29 JSnipes29 JSnipes29 approved these changes

Assignees

@trinif trinif

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trinif @JSnipes29 @rchhaya