Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gsr notifs2.0 #547

Closed
wants to merge 13 commits into from
Closed

Gsr notifs2.0 #547

wants to merge 13 commits into from

Conversation

rchhaya
Copy link
Contributor

@rchhaya rchhaya commented Oct 8, 2022

GSR Notifications with the following functionality

  • Notification comes up ~10 min prior and lasts until the start time of the GSR
  • Notification has a short text version (generic) and longer text version (w/ room number and timestamp)
  • Clicking notification opens the app but does NOT close the notification
  • Booking multiple GSRs at the same time creates multiple notifications (achieved by modifying MainAct companion object)
  • Booking and then canceling the GSR will remove the notification (achieved by modifying MainAct companion object)
  • If the GSR is scheduled within 10 minutes of the start time, no notification is sent (since the notification would be sent immediately and it would cancel after the GSR time starts which doesn't really make sense)
  • Lots of null checks and contains(key) checks to prevent crashes if something goes wrong

@gitguardian
Copy link

gitguardian bot commented Oct 27, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret a2e9b14 PennMobile/src/main/AndroidManifest.xml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@meiron03 meiron03 closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants