Add canaryleak to detect memory leaks

unregister local broadcast receiver in GsrReservationsFragment when fragment is destroyed to prevent memory leak. TODO: remove LocalBroadcastManager entirely because that shit deprecated. remove LocalBroadCastManager from HomeFragment since it is unused (and was causing memory leaks)
pennlabs · Feb 12, 2024 · 6bed148 · 6bed148
1 parent ce424c8
commit 6bed148
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 18 deletions.
diff --git a/PennMobile/build.gradle b/PennMobile/build.gradle
@@ -39,6 +39,8 @@ android {
 }
 
 dependencies {
+    debugImplementation 'com.squareup.leakcanary:leakcanary-android:3.0-alpha-1'
+
     implementation fileTree(include: ['*.jar'], dir: 'libs')
     implementation(platform("com.google.firebase:firebase-bom:31.5.0"))
 

diff --git a/PennMobile/src/main/java/com/pennapps/labs/pennmobile/GsrReservationsFragment.kt b/PennMobile/src/main/java/com/pennapps/labs/pennmobile/GsrReservationsFragment.kt
@@ -130,5 +130,8 @@ class GsrReservationsFragment : Fragment() {
             getReservations()
         }
     }
-
+    override fun onDestroy() {
+        super.onDestroy()
+        LocalBroadcastManager.getInstance(mActivity).unregisterReceiver(broadcastReceiver);
+    }
 }
diff --git a/PennMobile/src/main/java/com/pennapps/labs/pennmobile/HomeFragment.kt b/PennMobile/src/main/java/com/pennapps/labs/pennmobile/HomeFragment.kt
@@ -1,13 +1,8 @@
 package com.pennapps.labs.pennmobile
 
 import android.content.*
-import android.content.BroadcastReceiver
-import android.content.Context
-import android.content.Intent
-import android.content.IntentFilter
 import android.os.Bundle
 import android.os.Handler
-import android.util.Log
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
@@ -17,7 +12,6 @@ import androidx.fragment.app.viewModels
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.lifecycleScope
 import androidx.lifecycle.repeatOnLifecycle
-import androidx.localbroadcastmanager.content.LocalBroadcastManager
 import androidx.preference.PreferenceManager
 import androidx.recyclerview.widget.LinearLayoutManager
 import com.pennapps.labs.pennmobile.adapters.HomeAdapter
@@ -47,10 +41,6 @@ class HomeFragment : Fragment() {
 
         mActivity = activity as MainActivity
         sharedPreferences = PreferenceManager.getDefaultSharedPreferences(mActivity)
-
-        LocalBroadcastManager
-            .getInstance(mActivity)
-            .registerReceiver(broadcastReceiver, IntentFilter("refresh"))
     }
 
     override fun onCreateView(
@@ -188,13 +178,6 @@ class HomeFragment : Fragment() {
         }
     }
 
-
-    private val broadcastReceiver = object : BroadcastReceiver() {
-        override fun onReceive(context: Context?, intent: Intent?) {
-            getHomePage()
-        }
-    }
-
     override fun onResume() {
         super.onResume()
         mActivity.removeTabs()

diff --git a/PennMobile/src/main/java/com/pennapps/labs/pennmobile/MainActivity.kt b/PennMobile/src/main/java/com/pennapps/labs/pennmobile/MainActivity.kt
@@ -374,6 +374,7 @@ fun isOnline(context: Context?): Boolean {
     return false
 }
 
+
 /** Shows an error sneaker given a view group with an optional retry function */
 fun ViewGroup.showSneakerToast(message: String, doOnRetry: (() -> Unit)?, sneakerColor: Int) {
     val sneaker = Sneaker.with(this)