made pennkeys lowercase and changed test case

pennlabs · Oct 24, 2024 · 2b50939 · 2b50939
1 parent 00501b3
commit 2b50939
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/backend/courses/views.py b/backend/courses/views.py
@@ -520,7 +520,8 @@ def get_all_friendships(self):
 
     def post(self, request):
         sender = request.user
-        recipient = get_object_or_404(User, username=request.data.get("pennkey"))
+
+        recipient = get_object_or_404(User, username=request.data.get("pennkey").lower())
 
         existing_friendship = (
             self.get_all_friendships().filter(Q(recipient=recipient) | Q(sender=recipient)).first()
@@ -556,7 +557,7 @@ def delete(self, request):
         # (depends on who sends the request)
         res = {}
         sender = request.user
-        recipient = get_object_or_404(User, username=request.data.get("pennkey"))
+        recipient = get_object_or_404(User, username=request.data.get("pennkey").lower())
 
         existing_friendship = (
             self.get_all_friendships().filter(Q(recipient=recipient) | Q(sender=recipient)).first()

diff --git a/backend/tests/courses/test_friendship_models.py b/backend/tests/courses/test_friendship_models.py
@@ -27,7 +27,7 @@ def test_basic_friendship(self):
         self.assertTrue(UserProfile.objects.filter(user=u2).exists())
         self.assertTrue(UserProfile.objects.filter(user=u1).exists())
 
-        make_friends = self.client1.post(reverse("friendship"), {"pennkey": u2.username})
+        make_friends = self.client1.post(reverse("friendship"), {"pennkey": u2.username.upper()})
 
         self.assertEquals(make_friends.status_code, 201)
         self.assertTrue(