Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the colors for text & background to fit this year's theme (tr… #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cath3333
Copy link

@Cath3333 Cath3333 commented Jun 7, 2023

…ied dark background & lighter text but it didn't seem to match the aesthetics of the rest of the pages of the website). Added assets for the f23 logo as well. (issue #32)

…ied dark background & lighter text but it didn't seem to match the aesthetics of the rest of the pages of the website). Added assets for the f23 logo as well.
@Cath3333 Cath3333 requested a review from fyy26 June 7, 2023 07:49
Copy link
Contributor

@fyy26 fyy26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the logo have a cloudy gradient around it like the mobile landing page (talk to @geant04 about how he did it)

image

Also while this can be hard, I think using the same background color to make it consistent with our iteration website/theme is still important. I agree with the disruption, but keeping the nav bar the same unifies the website to some extent (maybe?) 🤔. You can play with the text color, I think yellow looks okay but too bright to the eye, while the nav bar kind of dim white is a bit dull. We can also discuss best design choices during this week's meeting, including how to make the page look non-disruptive while being characteristic of this year's theme.

image
Screen.Recording.2023-06-09.at.3.45.27.AM.mov

@fyy26
Copy link
Contributor

fyy26 commented Jun 9, 2023

Maybe the nav bar white as text color + logo with white ring of light like the mobile landing page can work. Generally a design shouldn't have too many colors in one page as well.

@Cath3333
Copy link
Author

Cath3333 commented Jun 12, 2023

Tried making the style consistent with the other pages but it looks...really bland because of how little content & formatting this page has compared to the rest (oops). I think the main issue is with the white background color and I would suggest maybe using pastel blue instead. p.s. the 'event site' button displays the effect when its on hover.

Screen Shot 2023-06-12 at 11 29 02 AM

@Cath3333
Copy link
Author

Maybe something like this?
Screen Shot 2023-06-12 at 11 40 09 AM

@Cath3333
Copy link
Author

Or even a gradient background (from the pastel blue above to a slightly darker violet)

Screen Shot 2023-06-12 at 11 52 06 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants