Update code for Ruff code style compliance

pelican/plugins/pdf/pdf.py

@@ -1,15 +1,14 @@
-"""
-PDF Generator
--------
+"""PDF Generator plugin for Pelican.
 
-The pdf plugin generates PDF files from reStructuredText and Markdown sources.
+This plugin generates PDF files from reStructuredText and Markdown source files.
 """
 
 from itertools import chain
 import logging
 import os
 import re
 import time
+from typing import ClassVar
 
 from rst2pdf.createpdf import RstToPdf
 
@@ -21,9 +20,9 @@
 
 
 class PdfGenerator(Generator):
-    "Generate PDFs on the output dir, for all articles and pages"
+    """Generate PDFs on the output dir, for all articles and pages."""
 
-    supported_md_fields = ["date"]
+    supported_md_fields: ClassVar[list[str]] = ["date"]
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -33,10 +32,7 @@ def __init__(self, *args, **kwargs):
         else:
             pdf_style_path = []
 
-        if "PDF_STYLE" in self.settings:
-            pdf_style = [self.settings["PDF_STYLE"]]
-        else:
-            pdf_style = []
+        pdf_style = [self.settings["PDF_STYLE"]] if "PDF_STYLE" in self.settings else []
 
         self.pdfcreator = RstToPdf(
             breakside=0, stylesheets=pdf_style, style_path=pdf_style_path, raw_html=True
@@ -95,7 +91,7 @@ def _create_pdf(self, obj, output_path):
         hrefs = self._get_intrasite_link_regex()
         text = hrefs.sub(lambda m: obj._link_replacer(obj.get_siteurl(), m), text)
 
-        logger.info(" [ok] writing %s" % output_pdf)
+        logger.info(f" [ok] writing {output_pdf}")
 
         self.pdfcreator.createPdf(text=(header + text), output=output_pdf)
 
@@ -104,11 +100,9 @@ def _create_pdf(self, obj, output_path):
 
     def _get_intrasite_link_regex(self):
         intrasite_link_regex = self.settings["INTRASITE_LINK_REGEX"]
-        regex = r"""
-                (?P<markup>)(?P<quote>)(?P<path>(\:?){}(?P<value>.*?)(?=[>\n]))
-                """.format(
-            intrasite_link_regex
-        )
+        regex = rf"""
+                (?P<markup>)(?P<quote>)(?P<path>(\:?){intrasite_link_regex}(?P<value>.*?)(?=[>\n]))
+                """
         return re.compile(regex, re.X)
 
     def _set_file_utime(self, path, datetime):
@@ -128,7 +122,7 @@ def generate_output(self, writer=None):
             try:
                 os.mkdir(pdf_path)
             except OSError:
-                logger.error("Couldn't create the pdf output folder in " + pdf_path)
+                logger.exception("Couldn't create the pdf output folder in " + pdf_path)
 
         for obj in chain(self.context["articles"], self.context["pages"]):
             self._create_pdf(obj, pdf_path)

pelican/plugins/pdf/test_pdf.py

@@ -4,16 +4,17 @@
 from tempfile import mkdtemp
 import unittest
 
+import pdf
 from pelican import Pelican
 from pelican.readers import MarkdownReader
 from pelican.settings import read_settings
 
-import pdf
-
 CUR_DIR = os.path.dirname(__file__)
 
 
 class TestPdfGeneration(unittest.TestCase):
+    """Test class for PDF generation."""
+
     def setUp(self, override=None):
         self.temp_path = mkdtemp(prefix="pelicantests.")
         settings = {