Adding address unit attribute to schema #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sweco-semhul
changed the title
orangejulius
approved these changes
Nov 14, 2017
| "peliasUnit": { | ||
| "type": "custom", | ||
| "tokenizer":"keyword", | ||
| "char_filter" : ["alphanumeric"], |
There was a problem hiding this comment.
@trescube do you think we would ever need non-alphanumeric characters in unit numbers? Maybe - or /?
There was a problem hiding this comment.
We've had a discussion and are pretty sure analyzing alphanumeric characters only will work well enough to start :)
|
yay thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve pelias/pelias#618 more details found in comments to that issue