Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for microstate Monaco #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Joxit
Copy link
Member

@Joxit Joxit commented Oct 7, 2022

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀

Monaco is a sovereign city-state and microstate, that means everything from locality to country are named Monaco. This causes a strange response from pelias (the first one):
/v1/autocomplete?sources=wof&lang=en&text=monaco

0) Monaco, Monaco
1) Monaco, Monaco
2) Monaco, Nelson Airport, NE, New Zealand
3) Taverna del Monaco, AV, Italy
4) Cozzo del Monaco, CS, Italy
5) Bosco del Monaco, RO, Italy
6) Tour de Monaco, Mur-de-Barrez, France
7) Hôtel de Monaco, Vic-sur-Cère, France
8) Synagogue de Monaco, Monaco, Monaco
9) Prince's Palace of Monaco, Monaco, Monaco

Here's what actually got changed 👏

For Monaco we display only the neighbourhood and country.


Here's how others can test the changes 👀

The previous response should display only Monaco

Some other example:
Before PR for Boulevard de belgique, Monaco

0) Boulevard de Belgique, Monaco, Monaco
1) Boulevard de Belgique, Monaco, Monaco
2) Moneghetti, MC, Monaco

After the PR:

Boulevard de Belgique, La Condamine, Monaco
Boulevard de Belgique, Fontvieille, Monaco
Moneghetti, La Condamine, Monaco

@Joxit Joxit force-pushed the joxit/feat/monaco branch from 285963a to e3bb3d4 Compare October 7, 2022 13:16
@Joxit Joxit requested a review from missinglink October 24, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant