complete v2 rewrite in vue #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this look like a reasonable way to enable github pages? Or is that something you've already taken care of? https://blog.usmanity.com/serving-vue-js-apps-on-github-pages/ |
|
that's what I was leaning towards, the only part I didn't like is where I
need to check in the compiled artifacts, but oh well.
The repo is actually already configured to output to docs/ for this reason
- it's just running "yarn build" and taking docs/ out of .gitignore. Give
me five min for a PR.
…On Fri, Mar 6, 2020 at 2:46 PM Julian Simioni ***@***.***> wrote:
Does this look like a reasonable way to enable github pages? Or is that
something you've already taken care of?
https://blog.usmanity.com/serving-vue-js-apps-on-github-pages/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AADMZMFBM6SOFTLST7IARDLRGFHI5A5CNFSM4LDGSQ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOCTALI#issuecomment-595931181>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMZMBZ2UDVKEAMWBD4VKTRGFHI5ANCNFSM4LDGSQ7Q>
.
--
*David Blackman*
creative technologist & wandering
help me find my purpose <http://purpose.blackmad.com>
|
|
PR sent
…On Fri, Mar 6, 2020 at 2:51 PM David Blackman ***@***.***> wrote:
that's what I was leaning towards, the only part I didn't like is where I
need to check in the compiled artifacts, but oh well.
The repo is actually already configured to output to docs/ for this reason
- it's just running "yarn build" and taking docs/ out of .gitignore. Give
me five min for a PR.
On Fri, Mar 6, 2020 at 2:46 PM Julian Simioni ***@***.***>
wrote:
> Does this look like a reasonable way to enable github pages? Or is that
> something you've already taken care of?
>
> https://blog.usmanity.com/serving-vue-js-apps-on-github-pages/
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#1?email_source=notifications&email_token=AADMZMFBM6SOFTLST7IARDLRGFHI5A5CNFSM4LDGSQ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOCTALI#issuecomment-595931181>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADMZMBZ2UDVKEAMWBD4VKTRGFHI5ANCNFSM4LDGSQ7Q>
> .
>
--
*David Blackman*
creative technologist & wandering
help me find my purpose <http://purpose.blackmad.com>
--
*David Blackman*
creative technologist & wandering
help me find my purpose <http://purpose.blackmad.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see original discussion at pelias-deprecated/compare-v1#21