[WIP] handle housenumbers that look like postcodes

[dianashk]

No description provided.

[missinglink]

would be nice to have code comments explaining why this behaviour is important (possibly with an example?), otherwise LGTM

[dianashk]

looks like the new libpostal release will handle this case. will leave this open until we can verify that no additional handling is needed.

[dianashk]

new libpostal is good at this and doesn't make these mistakes anymore.

[trescube]

libpostal still occasionally gets the number/postcode flipped. I'm going thru Orange County, CA right now and found the following examples where house number is parsed as postcode:

• 21161 HILLSDALE HUNTINGTON BEACH CA
• 24241 PORTO NUOVO DANA POINT CA
• 24855 CROWN ROYALE LAGUNA NIGUEL CA

It might be a good idea to keep this logic around.

[dianashk]

These cases are slightly different in that there aren't both a housenumber and a postalcode, but rather only the housenumber. In this case we can't assume libpostal got it wrong because it may not have. We might actually need to send queries with both and return anything that matches. Most likely sending both will reveal the clear winner.

[trescube]

In the US we might be able to work some magic since each state is allotted a range for postal codes:

https://en.wikipedia.org/wiki/ZIP_Code#/media/File:ZIP_Code_zones.svg

If libpostal returns a state, it wouldn't be hard to determine whether a zip code is likely a house number instead.

[dianashk]

add unit tests and acceptance tests and merge

[missinglink]

@dianashk please add code comments before merging.

I feel like, looking back on this in 6 months it wouldn't be clear what the original purpose of this code block was.

[dianashk]

move this over to API now that text-analyzer is no longer being used.

[dianashk]

Looks like this is still an issue and the fix should be merged.

21161 HILLSDALE HUNTINGTON BEACH CA

      {
        "controller:libpostal": {
          "parsed_text": {
            "postalcode": "21161",
            "neighbourhood": "hillsdale",
            "city": "huntington beach",
            "state": "ca"
          }
        }
      },