Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support choosing groups to lock #15

Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat: support choosing groups to lock #15

merged 2 commits into from
Jul 10, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming [email protected]

@frostming frostming requested a review from sigma67 July 9, 2024 07:51
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (1c6e877) to head (d6e0103).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   99.13%   99.15%   +0.02%     
==========================================
  Files           3        3              
  Lines         116      119       +3     
  Branches       25       26       +1     
==========================================
+ Hits          115      118       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sigma67 sigma67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest locked-groups= so it's easily recognizable next to locked as belonging together

Other than that it looks good to me

@frostming frostming merged commit 3d35f10 into main Jul 10, 2024
10 checks passed
@frostming frostming deleted the feat/lock-groups branch July 10, 2024 00:24
@sigma67
Copy link
Collaborator

sigma67 commented Jul 10, 2024

@frostming feel free to create 0.3.0 tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants