Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/MNT: Add main window, real test #2

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Feb 22, 2024

Description

  • adds blank main window, along with DesignerDisplay subclass from pcdsutils
  • Adds superscore ui cli entrypoiint, albeit without any arguments
  • Adds a real test for some ✅
  • updates dependencies for tests and docs
  • add pre-release note framework

Motivation and Context

Starting off this repo with some skeleton content

How Has This Been Tested?

Unit test added

Where Has This Been Documented?

This PR

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions

@tangkong tangkong requested a review from ZLLentz February 22, 2024 20:57
@tangkong
Copy link
Contributor Author

I'll request a review from @shilorigins officially once we get him added to the repo

@ZLLentz
Copy link
Member

ZLLentz commented Feb 22, 2024

There's not much to review here, it looks pretty normal framework-wise

@tangkong tangkong requested a review from shilorigins February 22, 2024 22:19
Copy link
Collaborator

@shilorigins shilorigins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with some of the packaging and documentation that's being done in the repo, so I'll get up to speed on that, but this PR looks good to me.

@tangkong tangkong merged commit 8ef9b33 into pcdshub:master Feb 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants