Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/BLD: push xml changes via deploy key #53

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Dec 13, 2024

Set up standard xml conversion/deployment workflow to use a deploy key. This is set up in conjunction with additional branch protections on this repository

This is something of an experiment. I'm trying to get behavior that combines:

  • applying branch protections (required reviews, checks)
  • ability for gha to push autogenerated xml without checks

The conceit here is that I can give github actions a deploy key / secret and add that as a bypass to the ruleset. Once this is merged we'll see for sure

Based on discussions and examples below:

@tangkong tangkong closed this Dec 13, 2024
@tangkong tangkong reopened this Dec 13, 2024
@tangkong tangkong closed this Dec 13, 2024
@tangkong tangkong reopened this Dec 13, 2024
@tangkong tangkong closed this Dec 13, 2024
@tangkong tangkong reopened this Dec 13, 2024
@tangkong tangkong requested a review from ZLLentz December 13, 2024 22:24
@tangkong
Copy link
Contributor Author

Aside from this, I can't get the ruleset to recognize the check we have here. The ruleset interface doesn't identify the running checks, and copying the name verbatim doesn't work. (simply specifying the name is how we do this for our other CI requirements)

@tangkong tangkong closed this Dec 13, 2024
@tangkong tangkong reopened this Dec 13, 2024
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is well-motivated.

We have to merge to really test it, right?

@tangkong
Copy link
Contributor Author

Yep, and what will surely follow is a slew of spammy bugfixes until I get it right

@tangkong tangkong merged commit 0b3e362 into pcdshub:master Dec 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants