Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NALMS pvs for MR2K2, MR3K2, and MR4K2 #26

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented Feb 6, 2024

added NALMS pvs for MR2K2, MR3K2, and MR4K2.

@nrwslac nrwslac requested a review from jyotiphy February 6, 2024 23:31
@tangkong
Copy link
Contributor

tangkong commented Feb 6, 2024

Did anything change in the first few lines of the file? The diff says something changed but I can't pick out what...

Otherwise the checks pass so it seems ok to merge

@nrwslac
Copy link
Contributor Author

nrwslac commented Feb 6, 2024

I cant tell. Editing a CSV file as the source across different OS and applications seems like a bad idea. @tangkong

@nrwslac
Copy link
Contributor Author

nrwslac commented Feb 6, 2024

I guess its easy enough to roll back if something breaks, ill merge it.

@nrwslac nrwslac merged commit fd318d3 into pcdshub:master Feb 6, 2024
1 check passed
@tangkong
Copy link
Contributor

tangkong commented Feb 6, 2024

I agree, but if the xml generates then things should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants