Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add FB_STRINGFromEPICS #53

Merged
merged 1 commit into from
Jul 21, 2021
Merged

ENH: add FB_STRINGFromEPICS #53

merged 1 commit into from
Jul 21, 2021

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Jul 12, 2021 •
edited
Loading

Addresses part of #52

Pairs with pcdshub/pytmc#268

Working so far

@klauer klauer mentioned this pull request Jul 12, 2021
Merged
@klauer klauer marked this pull request as ready for review July 19, 2021 22:21
ZLLentz
ZLLentz approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially the same as the other one, except the type is STRING, right?

@klauer
Copy link
Contributor Author

klauer commented Jul 21, 2021

Yes

@ZLLentz
Copy link
Member

ZLLentz commented Jul 21, 2021

LGTM

@ZLLentz ZLLentz merged commit 9f268cc into pcdshub:master Jul 21, 2021
@klauer klauer deleted the enh_link_str branch July 21, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klauer @ZLLentz